Review main Merged

94343[TASK] Use TranslatorInterface label() API in form TranslationService

Josua Vogel CR +2 V +2 Normal +58 −17 updated 06/10/26, 22:33

Commit message

Modernize TranslationService to use the TranslatorInterface label()
method introduced in TYPO3 14.2 instead of manually constructing
separate key/domain arguments.

Changes:
- Replace LanguageService::translate($key, $domain, ...) calls with
  the modern label($reference, ...) API in translate()
- Refactor processTranslationChain() to create the LanguageService
  only once per chain instead of once per key, reducing unnecessary
  object instantiation
- Extract applyTypoScriptOverrides() as a dedicated private method,
  removing duplicate inline logic
- Add extractFileReferenceFromKey() helper to resolve the file
  reference from a full label key for TypoScript override handling

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Josua Vogel uploaded patch set 1 06/05/26, 16:16

  2. core-ci voted on patch set 1 V +1 06/05/26, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103045

  3. Josua Vogel rebased onto patch set 2 V +1 06/10/26, 06:54

  4. core-ci voted on patch set 2 V +1 06/10/26, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103277

  5. Oliver Klee voted on patch set 2 CR +1 V +1 06/10/26, 11:11

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 06/10/26, 22:33

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 06/10/26, 22:33

  8. Stefan Bürk merged patch set 3 06/10/26, 22:33