Review 14.3 Merged

94344[BUGFIX] Fix string splitting and event binding for constant editor type "wrap"

Christian Kuhn CR +2 V +2 Easy +13 −17 updated 06/05/26, 20:56

Commit message

The Backend Extension Settings module renders two input fields for the
constant editor type "wrap" to split a configuration string by a pipe
character.

Two issues were fixed:

1. A copy-paste error caused the prefix value (index 0) to be assigned
   to both input fields, while the suffix value (index 1) was completely
   ignored. The second input field now correctly receives the suffix part
   of the split value.

2. The keyup event listeners for both "wrap" and "offset" fields were
   registered immediately after appending the custom LitElement to the
   DOM. Since LitElement renders asynchronously, the inner input fields
   did not yet exist at that point, resulting in no listeners being
   attached and changes not being written back to the hidden field.
   The fix replaces bindTo() on individual (not-yet-existing) inputs
   with delegateTo() on the parent element, so events are caught
   regardless of when the child inputs are rendered.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/05/26, 20:37

  2. core-ci voted on patch set 1 V +1 06/05/26, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103049

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/05/26, 20:56

  4. Christian Kuhn merged patch set 2 06/05/26, 20:56