94351[TASK] Avoid AbstractGridObject
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/AbstractGridObject.phpdeleted+0 −62
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/Grid.php+12 −1
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumn.php+15 −19
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php2+22 −3
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridRow.php2+12 −1
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/LanguageColumn.php+17 −3
Review log 1215
-
Christian Kuhn uploaded patch set 1 06/08/26, 01:09
-
core-ci voted on patch set 1 V +1 06/08/26, 01:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103095
-
Oliver Klee updated the commit message in patch set 2
V +106/08/26, 10:39 -
Oliver Klee commented on patch set 2 V +1 06/08/26, 10:43
GridRow.php:40Could/should we make all the `$context` properties `readonly`? -
Christian Kuhn commented on patch set 2 06/08/26, 10:45
GridColumnItem.php:71Replyno - due to manual constructors, unfortunately. this may need a bigger refactoring if at all possible with current construct. -
core-ci voted on patch set 2 V +1 06/08/26, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103117
-
Stefan Bürk voted on patch set 2 CR +1 V +1 06/08/26, 11:03
-
Christian Kuhn uploaded patch set 3
CR +1V +106/08/26, 11:17 -
Christian Kuhn commented on patch set 2 06/08/26, 11:17
GridRow.php:40ReplyDone -
Oliver Klee voted on patch set 3 CR +1 06/08/26, 11:20
-
core-ci voted on patch set 3 V +1 06/08/26, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103125
-
Oliver Klee voted on patch set 3 V +1 06/08/26, 11:29
-
Stefan Bürk voted on patch set 3 CR +1 V +1 06/09/26, 20:20
-
Christian Kuhn voted on patch set 3 CR +2 V +2 06/09/26, 20:22
-
Christian Kuhn merged patch set 4 06/09/26, 20:22
GridColumnItem.php:71