Review main Merged

94351[TASK] Avoid AbstractGridObject

Christian Kuhn CR +2 V +2 Normal +78 −89 updated 06/09/26, 20:22

Commit message

To simplify the construct around the BE layout module "grid",
the `@internal` `AbstractGridObject` class is inlined to consumers.
An unused method is removed along they way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1215

  1. Christian Kuhn uploaded patch set 1 06/08/26, 01:09

  2. core-ci voted on patch set 1 V +1 06/08/26, 01:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103095

  3. Oliver Klee updated the commit message in patch set 2 V +1 06/08/26, 10:39

  4. Oliver Klee commented on patch set 2 V +1 06/08/26, 10:43

    GridColumnItem.php:71

    Can't we inject the icon factory?

    GridRow.php:40

    Could/should we make all the `$context` properties `readonly`?
  5. Christian Kuhn commented on patch set 2 06/08/26, 10:45

    GridColumnItem.php:71 Reply

    no - due to manual constructors, unfortunately. this may need a bigger refactoring if at all possible with current construct.
  6. core-ci voted on patch set 2 V +1 06/08/26, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103117

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 06/08/26, 11:03

  8. Christian Kuhn uploaded patch set 3 CR +1 V +1 06/08/26, 11:17

  9. Christian Kuhn commented on patch set 2 06/08/26, 11:17

    GridRow.php:40 Reply

    Done
  10. Oliver Klee voted on patch set 3 CR +1 06/08/26, 11:20

  11. core-ci voted on patch set 3 V +1 06/08/26, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103125

  12. Oliver Klee voted on patch set 3 V +1 06/08/26, 11:29

  13. Stefan Bürk voted on patch set 3 CR +1 V +1 06/09/26, 20:20

  14. Christian Kuhn voted on patch set 3 CR +2 V +2 06/09/26, 20:22

  15. Christian Kuhn merged patch set 4 06/09/26, 20:22