94361[BUGFIX] Do not report collation error for sys_refindex:hash
Commit message
Review
-
Code review CR -1
- Josef Glatz -1
- Markus Klein -1
-
Verified V -1
- Josef Glatz -1
- core-ci +1 CI
Issues 1
Files 1
Review log 1314
-
Markus Klein uploaded patch set 1 06/08/26, 17:46
-
core-ci voted on patch set 1 V +1 06/08/26, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103145
-
Ravi Sachaniya voted on patch set 1 CR +1 V +1 06/09/26, 05:32
-
Markus Klein commented on patch set 1 06/09/26, 07:57
In order to see this error your settings.php must contain "DB/Connections/Default/defaultTableOptions/*" settings. -
Ravi Sachaniya commented on patch set 1 06/09/26, 07:59
Reply
correct, I have tested using below : ``` 'defaultTableOptions' => [ 'charset' => 'utf8mb4', 'collate' => 'utf8mb4_unicode_ci', ], ``` -
Markus Klein commented on patch set 1 CR -1 06/09/26, 08:29
@typo3@josefglatz.at is investigating this in more detail. Because on v14 with MariaDB 10.11 there are some more fields not matching, when installing from scratch -
Ravi Sachaniya commented on patch set 1 06/09/26, 08:42
Reply Unresolved
Acknowledged -
Ravi Sachaniya voted on patch set 1 CR 0 V 0 06/09/26, 08:43
-
Josef Glatz commented on patch set 1 CR -1 06/09/26, 09:38
on it -
Josef Glatz commented on patch set 1 06/09/26, 12:17
@markus.klein@typo3.org ### Looks like we have to handle more cases. #### Test Using the following SQL query: `select TABLE_NAME,COLUMN_NAME,DATA_TYPE,CHARACTER_SET_NAME,COLLATION_NAME,COLUMN_TYPE from information_schema.columns where table_schema = 'db' and collation_name <> 'utf8mb4_unicode_ci';` and having following DB/Connections/Default/defaultTableOptions: ``` 'defaultTableOptions' => [ 'charset' => 'utf8mb4', 'collation' => 'utf8mb4_unicode_ci', ], ``` on a fresh installed dev-main (v14.3.x-dev) instance. ##### Test results: MySql 8.4.5 `sys_refindex,hash,varchar,ascii,ascii_bin,varchar(32)` ##### Test results: MariaDb 10.11 ``` tx_styleguide_elements_basic,json_1,longtext,utf8mb4,utf8mb4_bin,longtext tx_styleguide_elements_basic,json_2,longtext,utf8mb4,utf8mb4_bin,longtext sys_reaction,fields,longtext,utf8mb4,utf8mb4_bin,longtext sys_webhook,additional_headers,longtext,utf8mb4,utf8mb4_bin,longtext tx_scheduler_task,parameters,longtext,utf8mb4,utf8mb4_bin,longtext tx_scheduler_task,execution_details,longtext,utf8mb4,utf8mb4_bin,longtext be_users,user_settings,longtext,utf8mb4,utf8mb4_bin,longtext sys_refindex,hash,varchar,ascii,ascii_bin,varchar(32) form_definition,configuration,longtext,utf8mb4,utf8mb4_bin,longtext ``` #### How can we deal with different DB backends? Looks like we have to respect different db backends for the UTF-8 check. --- **Not part of this patch:** I would also suggest to set the DefaultTableOptions mentioned above in core's DefaultConfiguration.php as strong – good – default. Maybe I lack foresight here and I'm not correct, but in my bubble it seems like this is a must-have, so I assume that this applies to 99% of TYPO3 projects because otherwise it relies on the DB backend which is also not consistent in my POV. -
Josef Glatz commented on patch set 1 06/09/26, 12:18
Reply
Done -
Josef Glatz commented on patch set 1 V -1 06/11/26, 01:47
Unresolved
@stefan@buerk.tech will have a look on it how to handle that. Needs another solution. -
Ravi Sachaniya wrote 07/09/26, 05:21
Removed reviewer Ravi Sachaniya. -
Markus Klein abandoned the change 10/02/26, 07:59
needs a broader fix