Review main Merged Breaking

94372[!!!][BUGFIX] Prevent exception when using `BU::daysUntil` w/ DateTime

Garvin Hicking CR +2 V +2 Normal +82 −3 updated 06/09/26, 06:32

Commit message

With #107356 the RecordList was adjusted to utilize RecordInterface
$row values, which meant that a field like `starttime` or
`endtime` might contain a `DateTime(Immutable)` object instead
of an integer timestamp.

The `BackendUtility::dasysUntil()` method only accepted integers,
and otherwise crashed with an exception. This happened for example
when IRRE child elements utilized these date fields.

An example for this was added to EXT:styleguide `Inline expandsingle`
records, and a test to cover this method to deal with both
integers and `DateTimeInterface` objects in `daysUntil`.

Please note the backport to v14.3 does not contain a type declaration
in the method to not be breaking. For v15, a new ReST changelog
file is added that will collect further strict type declarations
during v15 development.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 711

  1. Garvin Hicking uploaded patch set 1 06/08/26, 19:21

  2. core-ci voted on patch set 1 V -1 06/08/26, 19:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103156

  3. Garvin Hicking uploaded patch set 2 V -1 06/08/26, 19:41

  4. Garvin Hicking uploaded patch set 3 06/08/26, 19:42

  5. Garvin Hicking updated the commit message in patch set 4 06/08/26, 19:43

  6. core-ci voted on patch set 3 V +1 06/08/26, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103160

  7. core-ci voted on patch set 4 V +1 06/08/26, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103162

  8. core-ci voted on patch set 2 V -1 06/08/26, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103159

  9. Josua Vogel voted on patch set 4 CR +1 V +1 06/09/26, 05:23

  10. Benjamin Franzke voted on patch set 4 CR +2 V +2 06/09/26, 06:32

  11. Benjamin Franzke merged patch set 5 06/09/26, 06:32