Review main Merged

94438[TASK] Avoid failsafe container for installer

Benjamin Franzke CR +2 V +2 Normal +74 −89 updated 07/05/26, 18:58

Commit message

Failsafe mode is mandatory only for the maintenance tool.
Boot into the full symfony DI based container as early as
possible, to allow using all symfony DI features for
services in the install process.

This will allow to reduce services that needs to be provided
manually in service providers.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1825

  1. Benjamin Franzke uploaded patch set 1 06/09/26, 10:42

  2. core-ci voted on patch set 1 V +1 06/09/26, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103229

  3. Benjamin Franzke uploaded patch set 2 V +1 06/09/26, 10:56

  4. core-ci voted on patch set 2 V +1 06/09/26, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103230

  5. Benjamin Franzke rebased onto patch set 3 V +1 06/24/26, 08:20

  6. core-ci voted on patch set 3 V +1 06/24/26, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103798

  7. Benjamin Franzke rebased onto patch set 4 V +1 06/25/26, 10:38

  8. core-ci voted on patch set 4 V +1 06/25/26, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103871

  9. Benjamin Franzke uploaded patch set 5 V +1 07/01/26, 07:25

  10. core-ci voted on patch set 5 V +1 07/01/26, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104121

  11. Simon Schaufelberger voted on patch set 5 CR +1 07/01/26, 09:24

  12. Benjamin Franzke uploaded patch set 6 CR +1 V +1 07/01/26, 09:45

  13. core-ci voted on patch set 6 V +1 07/01/26, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104144

  14. Simon Schaufelberger commented on patch set 6 07/01/26, 10:30

    merge conflict ;(
  15. Benjamin Franzke commented on patch set 6 07/01/26, 10:42

    Reply

    yes/no, I've rebased on https://review.typo3.org/c/Packages/TYPO3.CMS/+/94636/5 so that there is no merge conflict, once that patch is merged. In other words: the merge conflict will be gone, once that patch is merged ;)
  16. Simon Schaufelberger commented on patch set 6 07/01/26, 10:50

    Reply

    ah ok, it's a relatoin chain again ;)
  17. Benni Mack voted on patch set 6 CR +1 V +1 07/01/26, 14:10

  18. Simon Schaufelberger voted on patch set 6 CR +1 V +1 07/01/26, 14:40

  19. Benjamin Franzke uploaded patch set 7 CR +1 V +1 07/03/26, 08:40

  20. Benjamin Franzke commented on patch set 7 07/03/26, 08:41

    Rebased
  21. core-ci voted on patch set 7 V +1 07/03/26, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104272

  22. Benni Mack voted on patch set 7 CR +1 V +1 07/03/26, 09:00

  23. Simon Schaufelberger voted on patch set 7 CR +1 V +1 07/03/26, 20:57

  24. Georg Ringer voted on patch set 7 CR +2 V +2 07/05/26, 18:58

  25. Georg Ringer merged patch set 8 07/05/26, 18:58