94438[TASK] Avoid failsafe container for installer
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/install/Classes/Command/SetupCommand.php+40 −25
- typo3/sysext/install/Classes/Controller/InstallerController.php+20 −25
- typo3/sysext/install/Classes/Middleware/Installer.php+8 −3
- typo3/sysext/install/Classes/Service/SetupDatabaseService.php+2 −0
- typo3/sysext/install/Classes/ServiceProvider.php+1 −36
- typo3/sysext/install/Configuration/Services.yaml+3 −0
Review log 1825
-
Benjamin Franzke uploaded patch set 1 06/09/26, 10:42
-
core-ci voted on patch set 1 V +1 06/09/26, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103229
-
Benjamin Franzke uploaded patch set 2
V +106/09/26, 10:56 -
core-ci voted on patch set 2 V +1 06/09/26, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103230
-
Benjamin Franzke rebased onto patch set 3
V +106/24/26, 08:20 -
core-ci voted on patch set 3 V +1 06/24/26, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103798
-
Benjamin Franzke rebased onto patch set 4
V +106/25/26, 10:38 -
core-ci voted on patch set 4 V +1 06/25/26, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103871
-
Benjamin Franzke uploaded patch set 5
V +107/01/26, 07:25 -
core-ci voted on patch set 5 V +1 07/01/26, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104121
-
Simon Schaufelberger voted on patch set 5 CR +1 07/01/26, 09:24
-
Benjamin Franzke uploaded patch set 6
CR +1V +107/01/26, 09:45 -
core-ci voted on patch set 6 V +1 07/01/26, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104144
-
Simon Schaufelberger commented on patch set 6 07/01/26, 10:30
merge conflict ;( -
Benjamin Franzke commented on patch set 6 07/01/26, 10:42
Reply
yes/no, I've rebased on https://review.typo3.org/c/Packages/TYPO3.CMS/+/94636/5 so that there is no merge conflict, once that patch is merged. In other words: the merge conflict will be gone, once that patch is merged ;) -
Simon Schaufelberger commented on patch set 6 07/01/26, 10:50
Reply
ah ok, it's a relatoin chain again ;) -
Benni Mack voted on patch set 6 CR +1 V +1 07/01/26, 14:10
-
Simon Schaufelberger voted on patch set 6 CR +1 V +1 07/01/26, 14:40
-
Benjamin Franzke uploaded patch set 7
CR +1V +107/03/26, 08:40 -
Benjamin Franzke commented on patch set 7 07/03/26, 08:41
Rebased -
core-ci voted on patch set 7 V +1 07/03/26, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104272
-
Benni Mack voted on patch set 7 CR +1 V +1 07/03/26, 09:00
-
Simon Schaufelberger voted on patch set 7 CR +1 V +1 07/03/26, 20:57
-
Georg Ringer voted on patch set 7 CR +2 V +2 07/05/26, 18:58
-
Georg Ringer merged patch set 8 07/05/26, 18:58