Review main Merged Breaking

94447[!!!][TASK] Remove LoggerAwareInterface from FormEngine abstracts

Christian Kuhn CR +2 V +2 Normal +95 −22 updated 06/10/26, 09:35

Commit message

The FormEngine AbstractNode and AbstractDatabaseRecordProvider
implemented LoggerAwareInterface together with LoggerAwareTrait,
so a logger was injected into every node and database record
provider after construction.

The patch drops the interface and the trait from both. TcaFiles
and TcaInline now receive a LoggerInterface via DI.

As both base classes are public extension points, subclasses no
longer get a logger injected automatically, so this change is
considered breaking.

As drive-by AbstractNode::initializeResultArray() gains a proper
array @return shape, replacing a local annotation. This surfaced
a stale, slightly wrong @return in styleguide.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 68

  1. Christian Kuhn uploaded patch set 1 06/09/26, 23:39

  2. core-ci voted on patch set 1 V +1 06/09/26, 23:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103254

  3. Garvin Hicking updated the commit message in patch set 2 V +1 06/10/26, 05:15

  4. core-ci voted on patch set 2 V +1 06/10/26, 05:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103270

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 06/10/26, 05:26

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 06/10/26, 09:30

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 06/10/26, 09:35

  8. Christian Kuhn merged patch set 3 06/10/26, 09:35