Review main Abandoned

94448[TASK] Use DI in admin panel SQL logging

Christian Kuhn CR -1 V -1 Normal +35 −32 updated 06/18/26, 22:57

Commit message

The admin panel records SQL queries through a Doctrine
driver middleware. DoctrineSqlLoggingMiddleware created
its DoctrineSqlLogger with makeInstance() inside wrap(),
and DoctrineSqlLogger in turn pulled its PSR logger
through LoggerAwareInterface.

The patch registers DoctrineSqlLoggingMiddleware as a public
GU::makeInstance() call in ConnectionPool resolves it through
the container and autowires its constructor. DoctrineSqlLogger
is now a constructor dependency of the middleware, and drops
LoggerAwareInterface in favor of a constructor LoggerInterface.
Both classes are declared final.

As drive-by DoctrineSqlLogger is renamed to $sqlLogger
consistently, so it no longer reads like the actual PSR
logger, and the Doctrine Middleware import is aliased
DoctrineMiddlewareInterface to not read like PSR-15
MiddlewareInterface.

Review

  • Code review CR -1
    • Christian Kuhn -1
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 5

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/10/26, 00:38

  2. core-ci voted on patch set 1 V -1 06/10/26, 00:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103256

  3. Christian Kuhn voted on patch set 1 CR -1 06/10/26, 01:31

  4. Christian Kuhn abandoned the change 06/18/26, 22:57