94451[BUGFIX] Silence unserialize() warnings in PHP >=8.3
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Andreas Kienast +1
- Oliver Hader +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Oliver Hader +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1220
-
Benjamin Franzke uploaded patch set 1 06/10/26, 08:02
-
core-ci voted on patch set 1 V +1 06/10/26, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103288
-
core-ci voted on patch set 1 V -1 06/10/26, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103289
-
core-ci commented on patch set 1 06/10/26, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103289
-
Benjamin Franzke rebased onto patch set 2
V -106/10/26, 10:12 -
core-ci voted on patch set 2 V -1 06/10/26, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103301
-
Christian Kuhn commented on patch set 2 06/10/26, 10:30
this probably fixes forge 110031, too? -
core-ci commented on patch set 2 06/10/26, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103303
-
Benjamin Franzke commented on patch set 2 06/10/26, 10:39
Reply
I guess, but the report is a bit uncocrete (no blaming, because there are probably no errors printed), so that I'm not 100% sure, since I'm not able to reproduce the warnings locally with PHP 8.5, only with the testing containers. I'd personally opt for clarification in those tickets (both https://forge.typo3.org/issues/110030 and https://forge.typo3.org/issues/110031) first. -
Benjamin Franzke rebased onto patch set 3
V -106/10/26, 10:42 -
Christian Kuhn commented on patch set 3 06/10/26, 10:56
Reply
good. i related the issues as a first step. -
Benjamin Franzke commented on patch set 3 06/10/26, 10:57
Reply
sound good, thanks -
core-ci voted on patch set 3 V +1 06/10/26, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103310
-
Oliver Klee voted on patch set 3 CR +1 V +1 06/10/26, 11:12
-
core-ci voted on patch set 3 V -1 06/10/26, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103313
-
core-ci voted on patch set 3 V +1 06/10/26, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103313
-
Andreas Kienast voted on patch set 3 CR +1 06/10/26, 13:55
-
Oliver Hader voted on patch set 3 CR +1 V +1 06/10/26, 14:00
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 06/10/26, 14:19
-
Benjamin Franzke merged patch set 4 06/10/26, 14:20