Review main Merged

94451[BUGFIX] Silence unserialize() warnings in PHP >=8.3

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 06/10/26, 14:20

Commit message

During initial TYPO3 setup, there may have been
cache entries (e.g. for icons) that were generated before
the initial encryption key has been created. In this case
unserialization will throw warnings, since we do not
crop of the invalid hash. We might refactor this
later, but for now the warning is silenced in order
to ensure the setup can still be installed.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1220

  1. Benjamin Franzke uploaded patch set 1 06/10/26, 08:02

  2. core-ci voted on patch set 1 V +1 06/10/26, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103288

  3. core-ci voted on patch set 1 V -1 06/10/26, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103289

  4. core-ci commented on patch set 1 06/10/26, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103289

  5. Benjamin Franzke rebased onto patch set 2 V -1 06/10/26, 10:12

  6. core-ci voted on patch set 2 V -1 06/10/26, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103301

  7. Christian Kuhn commented on patch set 2 06/10/26, 10:30

    this probably fixes forge 110031, too?
  8. core-ci commented on patch set 2 06/10/26, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103303

  9. Benjamin Franzke commented on patch set 2 06/10/26, 10:39

    Reply

    I guess, but the report is a bit uncocrete (no blaming, because there are probably no errors printed), so that I'm not 100% sure, since I'm not able to reproduce the warnings locally with PHP 8.5, only with the testing containers. I'd personally opt for clarification in those tickets (both https://forge.typo3.org/issues/110030 and https://forge.typo3.org/issues/110031) first.
  10. Benjamin Franzke rebased onto patch set 3 V -1 06/10/26, 10:42

  11. Christian Kuhn commented on patch set 3 06/10/26, 10:56

    Reply

    good. i related the issues as a first step.
  12. Benjamin Franzke commented on patch set 3 06/10/26, 10:57

    Reply

    sound good, thanks
  13. core-ci voted on patch set 3 V +1 06/10/26, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103310

  14. Oliver Klee voted on patch set 3 CR +1 V +1 06/10/26, 11:12

  15. core-ci voted on patch set 3 V -1 06/10/26, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103313

  16. core-ci voted on patch set 3 V +1 06/10/26, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103313

  17. Andreas Kienast voted on patch set 3 CR +1 06/10/26, 13:55

  18. Oliver Hader voted on patch set 3 CR +1 V +1 06/10/26, 14:00

  19. Benjamin Franzke voted on patch set 3 CR +2 V +2 06/10/26, 14:19

  20. Benjamin Franzke merged patch set 4 06/10/26, 14:20