Review main Merged

94454[BUGFIX] Use correct label key for doktype label

Oli Bartsch CR +2 V +2 Easy +7 −7 updated 06/10/26, 15:54

Commit message

In #17406, the xlf file was initially named
`Language/db/pages/doktype.xlf` and then moved to
`Language/db/pages.xlf` in #109197 without adjustment
to the utilized language labels.

This is now fixed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 912

  1. Oli Bartsch uploaded patch set 1 06/10/26, 09:57

  2. core-ci voted on patch set 1 V +1 06/10/26, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103297

  3. Christian Kuhn commented on patch set 1 06/10/26, 10:18

    PageLinkMessageProvider.php:114

    reads as if this is affected, too?
  4. Oli Bartsch uploaded patch set 2 V +1 06/10/26, 11:16

  5. Oli Bartsch commented on patch set 2 06/10/26, 11:16

    PageLinkMessageProvider.php:114 Reply

    Yep
  6. core-ci voted on patch set 2 V -1 06/10/26, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103318

  7. Garvin Hicking rebased onto patch set 3 V -1 06/10/26, 15:10

  8. Garvin Hicking commented on patch set 3 CR +1 V +1 06/10/26, 15:11

    (adjusted the commit message for explanation, rebased, related issues)
  9. core-ci voted on patch set 3 V +1 06/10/26, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103351

  10. Josua Vogel voted on patch set 3 CR +1 V +1 06/10/26, 15:45

  11. Oli Bartsch commented on patch set 3 CR +2 V +2 06/10/26, 15:54

    Reply

    Thanks.
  12. Oli Bartsch merged patch set 4 06/10/26, 15:54