Review 14.3 Merged

94456[BUGFIX] Do not persist VirtualAppPackage to PackageStates.php

Christian Kuhn CR +2 V +2 Easy +25 −1 updated 06/10/26, 21:50

Commit message

The VirtualAppPackage ("typo3/app") is a virtual root package
that is registered manually during PackageManager initialization
after all real packages have been pulled in from disk. It must
never end up in PackageStates.php: on write it leaked in because
savePackageStates() exported the full configuration, and on read
a leftover entry would be turned into a regular Package object,
colliding with the freshly registered VirtualAppPackage
("Package typo3/app is already registered").

savePackageStates() now strips the app package before writing,
and loadPackageStates() drops a leftover entry before registration,
so instances that already persisted "typo3/app" keep booting and
the entry is cleaned up on the next save.

The patch also updates the ext_emconf.php deprecation changelog
to clarify that the extension version and the "providesPackages"
definition become mandatory composer.json fields in v15.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 06/10/26, 10:39

  2. core-ci voted on patch set 1 V +1 06/10/26, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103305

  3. Oliver Klee voted on patch set 1 CR +1 V +1 06/10/26, 11:12

  4. Helmut Hummel voted on patch set 1 CR +1 06/10/26, 11:21

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 06/10/26, 21:50

  6. Stefan Bürk merged patch set 2 06/10/26, 21:50