Review main Merged

94457[TASK] Adapt form_storage_tests to #109993 requirements

Benjamin Franzke CR +2 V +2 Easy +12 −2 updated 06/10/26, 11:44

Commit message

With #110015 a new test extension has been introduced
which has incomplete composer.json. This was not caught
because the pre-merge of #109993 was performed prior
to the merge of #109993.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Josua Vogel +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Josua Vogel +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 1214

  1. Benjamin Franzke uploaded patch set 1 06/10/26, 10:40

  2. Benjamin Franzke rebased onto patch set 2 06/10/26, 10:42

  3. Christian Kuhn commented on patch set 1 06/10/26, 10:44

    foo. thx for very quick action! unrisky target for v14 as well, i suppose?
  4. Benjamin Franzke commented on patch set 2 06/10/26, 10:47

    Reply

    ack, I forgot that > 91908: [FEATURE] Allow extensions to move ext_emconf.php info to composer.json | https://review.typo3.org/c/Packages/TYPO3.CMS/+/91908 already changed these files in v14. will adapt.
  5. Benjamin Franzke updated the commit message in patch set 3 06/10/26, 10:47

  6. Christian Kuhn commented on patch set 3 06/10/26, 10:54

    Reply

    works. let's bring it in without much further ado when green to unblock the others.
  7. Christian Kuhn voted on patch set 3 CR +1 V +1 06/10/26, 10:54

  8. core-ci voted on patch set 2 V +1 06/10/26, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103308

  9. core-ci voted on patch set 3 V +1 06/10/26, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103312

  10. Oliver Klee voted on patch set 3 CR +1 V +1 06/10/26, 11:11

  11. Oliver Hader voted on patch set 3 CR +1 V +1 06/10/26, 11:36

  12. Josua Vogel voted on patch set 3 CR +1 V +1 06/10/26, 11:38

  13. Benjamin Franzke voted on patch set 3 CR +2 V +2 06/10/26, 11:44

  14. Benjamin Franzke merged patch set 4 06/10/26, 11:44