Review main Merged

94465[BUGFIX] Derive page module view mode from the current page

Oli Bartsch CR +2 V +2 Hard +255 −35 updated 09/21/26, 13:16

Commit message

The "view mode" of the page module is stored per backend user, but
was evaluated with two different criteria: the mode menu offered
language comparison only for pages that actually have translations,
while rendering, doc header buttons and the language selector read the
stored value directly. The menu additionally reset that value after it
had already been persisted, so the reset never survived the request.

A page without translations in a multi language site was therefore
drawn through the comparison path, collapsing a multi column backend
layout into a single column, while its doc header acted as if layout
mode were active. Blinding the comparison mode via page TSconfig was
ignored for rendering for the same reason.

The available modes and the resulting effective mode are now determined
in one place and used by every consumer. The stored preference is never
overwritten, so a page without translations falls back to layout mode
without losing the preference for the next page that has translations.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1015

  1. Oli Bartsch uploaded patch set 1 06/10/26, 11:42

  2. core-ci voted on patch set 1 V -1 06/10/26, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103321

  3. core-ci commented on patch set 1 06/10/26, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103321

  4. Oli Bartsch rebased onto patch set 2 V -1 06/10/26, 15:42

  5. core-ci voted on patch set 2 V +1 06/10/26, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103353

  6. Josua Vogel voted on patch set 2 CR +1 06/12/26, 06:09

  7. Oli Bartsch uploaded patch set 3 CR +1 V +1 09/18/26, 21:02

  8. core-ci voted on patch set 3 V +1 09/18/26, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108820

  9. Oli Bartsch uploaded patch set 4 V +1 09/18/26, 21:37

  10. Oli Bartsch commented on patch set 4 09/18/26, 21:38

    This change is ready for review.
  11. core-ci voted on patch set 4 V +1 09/18/26, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108821

  12. Simon Schaufelberger voted on patch set 4 CR +1 V +1 09/18/26, 22:58

  13. Benni Mack voted on patch set 4 CR +1 V +1 09/21/26, 01:32

  14. Oli Bartsch voted on patch set 4 CR +2 V +2 09/21/26, 13:16

  15. Oli Bartsch merged patch set 5 09/21/26, 13:16