94470[BUGFIX] Use correct index as identifier in UploadedResourceViewHelper
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 1
Review log 911
-
Nikita Hovratov uploaded patch set 1 06/10/26, 13:34
-
Nikita Hovratov commented on patch set 1 06/10/26, 13:34
Note: The GitLab CI job in question: https://git.typo3.org/typo3/CI/cms/-/jobs/5689859 -
core-ci voted on patch set 1 V +1 06/10/26, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103343
-
Nikita Hovratov updated the commit message in patch set 2
V +106/10/26, 13:49 -
core-ci voted on patch set 2 V +1 06/10/26, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103344
-
Oliver Klee voted on patch set 2 CR +1 V +1 06/10/26, 15:08
-
Garvin Hicking commented on patch set 2 CR +1 V +1 06/10/26, 16:41
Oh, good catch - I did not notice this behaviour on my tests, I'm sorry. -
Christian Kuhn commented on patch set 2 CR +1 06/10/26, 21:14
Yes. And thank you! And I think we should finally resolve forge #73717 as well in v15 (because it is slightly breaking, probably). I have something in stash but simply didn't find the time to finish it, yet. This is the flaky test I mentioned in https://typo3.slack.com/archives/C03AM9R17/p1780885250476679 as well. -
Christian Kuhn voted on patch set 2 V +1 06/10/26, 22:10
-
Christian Kuhn voted on patch set 2 CR +2 V +2 06/10/26, 22:21
-
Christian Kuhn merged patch set 3 06/10/26, 22:21