Review main Merged

94470[BUGFIX] Use correct index as identifier in UploadedResourceViewHelper

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 06/10/26, 22:21

Commit message

The key in the foreach of an ObjectStorage is not an integer, but the
spl_object_hash of the object. Converting this to an int results in
PHP type juggling random string values like "00005efd0000" to "5". This
leads to exactly the opposite of the intended unique identifier fix from
#109827.

Note: This was revealed by a random functional test job in GitLab CI,
which by chance led to two same identifiers.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Nikita Hovratov uploaded patch set 1 06/10/26, 13:34

  2. Nikita Hovratov commented on patch set 1 06/10/26, 13:34

    Note: The GitLab CI job in question: https://git.typo3.org/typo3/CI/cms/-/jobs/5689859
  3. core-ci voted on patch set 1 V +1 06/10/26, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103343

  4. Nikita Hovratov updated the commit message in patch set 2 V +1 06/10/26, 13:49

  5. core-ci voted on patch set 2 V +1 06/10/26, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103344

  6. Oliver Klee voted on patch set 2 CR +1 V +1 06/10/26, 15:08

  7. Garvin Hicking commented on patch set 2 CR +1 V +1 06/10/26, 16:41

    Oh, good catch - I did not notice this behaviour on my tests, I'm sorry.
  8. Christian Kuhn commented on patch set 2 CR +1 06/10/26, 21:14

    Yes. And thank you! And I think we should finally resolve forge #73717 as well in v15 (because it is slightly breaking, probably). I have something in stash but simply didn't find the time to finish it, yet. This is the flaky test I mentioned in https://typo3.slack.com/archives/C03AM9R17/p1780885250476679 as well.
  9. Christian Kuhn voted on patch set 2 V +1 06/10/26, 22:10

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 06/10/26, 22:21

  11. Christian Kuhn merged patch set 3 06/10/26, 22:21