Review main Merged

94473[BUGFIX] Make cache `NullBackend` transient

Helmut Hummel CR +2 V +2 Easy +3 −3 updated 06/11/26, 09:03

Commit message

It does not make sense that the `VariableFrontend`
serializes data, that is then immediately discarded in `NullBackend`.

Instead the serialization can be skipped altogether.
This can be done by making the `NullBackend` implement the
`TransientBackendInterface`, as `VariableFrontend` checks for
this interface to skip serialization.

To fix the regression, it is also ensured that the assets cache
in fact uses a NullBackend in early boot/install tool/setup.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1012

  1. Helmut Hummel uploaded patch set 1 06/10/26, 18:56

  2. Oliver Klee updated the commit message in patch set 2 06/10/26, 18:58

  3. core-ci voted on patch set 1 V +1 06/10/26, 19:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103356

  4. core-ci voted on patch set 2 V +1 06/10/26, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103357

  5. Oliver Klee voted on patch set 2 CR +1 V +1 06/10/26, 19:13

  6. Christian Kuhn voted on patch set 2 CR +1 06/10/26, 21:16

  7. Stefan Bürk voted on patch set 2 CR +1 06/10/26, 21:59

  8. Stefan Bürk voted on patch set 2 V +1 06/10/26, 22:00

  9. Benjamin Franzke voted on patch set 2 CR +1 06/11/26, 05:42

  10. Benjamin Franzke voted on patch set 2 CR +2 V +2 06/11/26, 05:50

  11. Benjamin Franzke merged patch set 3 06/11/26, 06:01

  12. Helmut Hummel commented on patch set 3 06/11/26, 09:03

    Thanks for the reviews and the quick merge!