Review main Merged

94495[BUGFIX] Allow scheduler tasks with logger references to be deserialized

Benjamin Franzke CR +2 V +2 Easy +7 −1 updated 06/16/26, 06:12

Commit message

Prior to #86785 a serialized scheduler task contained
a reference to the logger instance that was used.

The change that removed this on serialize is quite
old (<9.5.3), therefore the likelihood to encounter those
record is quote low, but there may still be instances around
that have older records, since they may not have been migrated,
since they are updated ondemand on save.

The affected tasks will be migrated as of v14 via
`SchedulerDatabaseStorageMigration` though, but we need
to ensure that this migration is still able to deserialize
these old records.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1720

  1. Benjamin Franzke commented on patch set 1 06/11/26, 11:48

    Cherry Picked from branch 13.4. The following files contain Git conflicts: * typo3/sysext/scheduler/Tests/Unit/Task/TaskSerializerTest.php
  2. Benjamin Franzke uploaded patch set 2 06/11/26, 11:56

  3. Benjamin Franzke commented on patch set 2 CR -1 06/11/26, 11:57

    ugh, the test doesn't fail without the fix (need to check again)
  4. Benjamin Franzke marked it work in progress 06/11/26, 11:57

  5. core-ci voted on patch set 1 V -1 06/11/26, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103391

  6. core-ci voted on patch set 2 V -1 06/11/26, 12:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103392

  7. Benjamin Franzke uploaded patch set 3 CR -1 V -1 06/11/26, 12:43

  8. Benjamin Franzke commented on patch set 3 06/11/26, 12:43

    Reply

    Done
  9. core-ci voted on patch set 3 V +1 06/11/26, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103396

  10. Oliver Hader voted on patch set 3 CR +1 06/11/26, 12:55

  11. Christian Kuhn commented on patch set 3 06/11/26, 14:42

    DefaultConfiguration.php:204

    i think we could declare this could be removed in v16 when SchedulerDatabaseStorageMigration is removed?
  12. Garvin Hicking commented on patch set 3 06/11/26, 17:44

    DefaultConfiguration.php:204 Reply

    At best both here and in the Migration wizard itself to remind ourselves, ack
  13. Benjamin Franzke commented on patch set 3 06/12/26, 06:06

    DefaultConfiguration.php:204 Reply

    Thought about such a comment as well, on the other hand: Logger might be serialized in other cases as well (not good, but possible). Think of extbase models. I think it should persist as long as `DenyListSerializer` exists – which we hopefully remove sooner than later, by replacing all the serialize usages (which we couldn't do in security backports). My "hope" is: It can already be removed in v15, in case we manage to replace all `DenyListSerializer` usages. (It's meant as a short-term solution and not long-term, if I got @oliver.hader@typo3.org right)
  14. Andreas Kienast voted on patch set 3 CR +1 V +1 06/15/26, 17:55

  15. Oliver Hader voted on patch set 3 V +1 06/15/26, 19:29

  16. Simon Schaufelberger voted on patch set 3 CR +1 V +1 06/15/26, 19:37

  17. Oliver Hader voted on patch set 3 CR +2 V +2 06/16/26, 06:08

  18. Oliver Hader merged patch set 4 06/16/26, 06:08

  19. Oliver Hader commented on patch set 4 06/16/26, 06:10

    DefaultConfiguration.php:204 Reply

    Concerning the comments and what/where to "declare"... I don't know, please adjust/comment on your own in a new change, thx 😊
  20. Oliver Hader commented on patch set 4 06/16/26, 06:12

    DefaultConfiguration.php:204 Reply Unresolved

    Getting rid of blunt PHP deserialization would be great, but it also requires lots of changes to the architectural foundation of TYPO3.