94495[BUGFIX] Allow scheduler tasks with logger references to be deserialized
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Andreas Kienast +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oliver Hader +2
- Andreas Kienast +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 3
Files 3
Review log 1720
-
Benjamin Franzke commented on patch set 1 06/11/26, 11:48
Cherry Picked from branch 13.4. The following files contain Git conflicts: * typo3/sysext/scheduler/Tests/Unit/Task/TaskSerializerTest.php -
Benjamin Franzke uploaded patch set 2 06/11/26, 11:56
-
Benjamin Franzke commented on patch set 2 CR -1 06/11/26, 11:57
ugh, the test doesn't fail without the fix (need to check again) -
Benjamin Franzke marked it work in progress 06/11/26, 11:57
-
core-ci voted on patch set 1 V -1 06/11/26, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103391
-
core-ci voted on patch set 2 V -1 06/11/26, 12:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103392
-
Benjamin Franzke uploaded patch set 3
CR -1V -106/11/26, 12:43 -
Benjamin Franzke commented on patch set 3 06/11/26, 12:43
Reply
Done -
core-ci voted on patch set 3 V +1 06/11/26, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103396
-
Oliver Hader voted on patch set 3 CR +1 06/11/26, 12:55
-
Christian Kuhn commented on patch set 3 06/11/26, 14:42
DefaultConfiguration.php:204i think we could declare this could be removed in v16 when SchedulerDatabaseStorageMigration is removed? -
Garvin Hicking commented on patch set 3 06/11/26, 17:44
DefaultConfiguration.php:204ReplyAt best both here and in the Migration wizard itself to remind ourselves, ack -
Benjamin Franzke commented on patch set 3 06/12/26, 06:06
DefaultConfiguration.php:204ReplyThought about such a comment as well, on the other hand: Logger might be serialized in other cases as well (not good, but possible). Think of extbase models. I think it should persist as long as `DenyListSerializer` exists – which we hopefully remove sooner than later, by replacing all the serialize usages (which we couldn't do in security backports). My "hope" is: It can already be removed in v15, in case we manage to replace all `DenyListSerializer` usages. (It's meant as a short-term solution and not long-term, if I got @oliver.hader@typo3.org right) -
Andreas Kienast voted on patch set 3 CR +1 V +1 06/15/26, 17:55
-
Oliver Hader voted on patch set 3 V +1 06/15/26, 19:29
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 06/15/26, 19:37
-
Oliver Hader voted on patch set 3 CR +2 V +2 06/16/26, 06:08
-
Oliver Hader merged patch set 4 06/16/26, 06:08
-
Oliver Hader commented on patch set 4 06/16/26, 06:10
DefaultConfiguration.php:204ReplyConcerning the comments and what/where to "declare"... I don't know, please adjust/comment on your own in a new change, thx 😊 -
Oliver Hader commented on patch set 4 06/16/26, 06:12
DefaultConfiguration.php:204Reply UnresolvedGetting rid of blunt PHP deserialization would be great, but it also requires lots of changes to the architectural foundation of TYPO3.