Review main Merged

94505[TASK] Prevent PHPUnit warnings on ReflectionService destructor

Garvin Hicking CR +2 V +2 Easy +9 −1 updated 06/26/26, 19:19

Commit message

Under certain circumstances the PHPUnit functional tests may
call extbase reflection service and keep reflection state around that is
destructed after test execution.

This happened after #108604 added a dependency to the HashService
to the VariableFrontend for caching reflection state.

The reliance on having `$GLOBALS['TYPO3_CONF_VARS']` to exist
for proper destruction fails in instances where these variables
are restored to non-matching states.

This patch adds a hard dependency to the existence of that
variable, so that the data caches will not produce a PHP warning
of missing encryption keys when being called.

Patchset 4 carries an example where this issue surfaces due to
test orders.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1930

Show 35 earlier messages
  1. Garvin Hicking uploaded patch set 1 06/12/26, 11:15

  2. core-ci voted on patch set 1 V -1 06/12/26, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103443

  3. Garvin Hicking uploaded patch set 2 V -1 06/12/26, 11:46

  4. core-ci voted on patch set 2 V -1 06/12/26, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103445

  5. Garvin Hicking uploaded patch set 3 V -1 06/12/26, 11:56

  1. core-ci voted on patch set 3 V -1 06/12/26, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103446

  2. Garvin Hicking commented on patch set 3 06/12/26, 12:09

  3. Garvin Hicking uploaded patch set 4 V -1 06/12/26, 16:31

  4. core-ci voted on patch set 4 V +1 06/12/26, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103451

  5. Garvin Hicking commented on patch set 4 06/25/26, 03:10

  6. Garvin Hicking uploaded patch set 5 V +1 06/26/26, 11:28

  7. Garvin Hicking uploaded patch set 6 06/26/26, 11:29

  8. Oliver Klee voted on patch set 6 CR +1 06/26/26, 11:29

  9. Simon Schaufelberger voted on patch set 6 CR +1 V +1 06/26/26, 11:31

  10. core-ci voted on patch set 5 V +1 06/26/26, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103938

  11. core-ci voted on patch set 6 V -1 06/26/26, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103939

  12. Oliver Klee voted on patch set 6 V +1 06/26/26, 11:47

  13. Stefan Bürk commented on patch set 6 CR -1 06/26/26, 11:51

    FunctionalTests-Job-4.xml:1

    That file **must** not be committed. Functional test split - whas this a manual change/enforce or why it has been committed to the change ? Should be on gitignore anyway.
  14. Garvin Hicking commented on patch set 6 06/26/26, 11:54

    FunctionalTests-Job-4.xml:1 Reply

    It's already out of the patchset, please see patchset 6 (CI currently failing is due to git.typo3.org being loaded - will retry later)
  15. core-ci commented on patch set 6 06/26/26, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103939

  16. core-ci commented on patch set 6 06/26/26, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103939

  17. core-ci commented on patch set 6 06/26/26, 12:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103939

  18. Benjamin Franzke voted on patch set 6 CR +1 V +1 06/26/26, 13:09

  19. Benjamin Franzke voted on patch set 6 CR +2 V +2 06/26/26, 13:13

  20. core-ci commented on patch set 6 06/26/26, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103939

  21. core-ci voted on patch set 6 V +1 06/26/26, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103939

  22. Stefan Bürk voted on patch set 6 CR 0 06/26/26, 17:42

  23. Stefan Bürk voted on patch set 6 CR +1 V +1 06/26/26, 17:42

  24. Stefan Bürk commented on patch set 6 06/26/26, 17:43

    FunctionalTests-Job-4.xml:1 Reply

    I reloaded it twice and still saw the file. Sorry for the noise.
  25. Garvin Hicking merged patch set 7 06/26/26, 19:19