94505[TASK] Prevent PHPUnit warnings on ReflectionService destructor
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Stefan Bürk +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Stefan Bürk +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1930
Show 35 earlier messages
-
Garvin Hicking uploaded patch set 1 06/12/26, 11:15
-
core-ci voted on patch set 1 V -1 06/12/26, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103443
-
Garvin Hicking uploaded patch set 2
V -106/12/26, 11:46 -
core-ci voted on patch set 2 V -1 06/12/26, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103445
-
Garvin Hicking uploaded patch set 3
V -106/12/26, 11:56
-
core-ci voted on patch set 3 V -1 06/12/26, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103446
-
Garvin Hicking commented on patch set 3 06/12/26, 12:09
Slack thread: https://typo3.slack.com/archives/C03AM9R17/p1781259105863119 -
Garvin Hicking uploaded patch set 4
V -106/12/26, 16:31 -
core-ci voted on patch set 4 V +1 06/12/26, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103451
-
Garvin Hicking commented on patch set 4 06/25/26, 03:10
-
Garvin Hicking uploaded patch set 5
V +106/26/26, 11:28 -
Garvin Hicking uploaded patch set 6 06/26/26, 11:29
-
Oliver Klee voted on patch set 6 CR +1 06/26/26, 11:29
-
Simon Schaufelberger voted on patch set 6 CR +1 V +1 06/26/26, 11:31
-
core-ci voted on patch set 5 V +1 06/26/26, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103938
-
core-ci voted on patch set 6 V -1 06/26/26, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103939
-
Oliver Klee voted on patch set 6 V +1 06/26/26, 11:47
-
Stefan Bürk commented on patch set 6 CR -1 06/26/26, 11:51
FunctionalTests-Job-4.xml:1That file **must** not be committed. Functional test split - whas this a manual change/enforce or why it has been committed to the change ? Should be on gitignore anyway. -
Garvin Hicking commented on patch set 6 06/26/26, 11:54
FunctionalTests-Job-4.xml:1ReplyIt's already out of the patchset, please see patchset 6 (CI currently failing is due to git.typo3.org being loaded - will retry later) -
core-ci commented on patch set 6 06/26/26, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103939
-
core-ci commented on patch set 6 06/26/26, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103939
-
core-ci commented on patch set 6 06/26/26, 12:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103939
-
Benjamin Franzke voted on patch set 6 CR +1 V +1 06/26/26, 13:09
-
Benjamin Franzke voted on patch set 6 CR +2 V +2 06/26/26, 13:13
-
core-ci commented on patch set 6 06/26/26, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103939
-
core-ci voted on patch set 6 V +1 06/26/26, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103939
-
Stefan Bürk voted on patch set 6 CR 0 06/26/26, 17:42
-
Stefan Bürk voted on patch set 6 CR +1 V +1 06/26/26, 17:42
-
Stefan Bürk commented on patch set 6 06/26/26, 17:43
FunctionalTests-Job-4.xml:1ReplyI reloaded it twice and still saw the file. Sorry for the noise. -
Garvin Hicking merged patch set 7 06/26/26, 19:19