Review main Merged

94511[BUGFIX] Respect tsconfig field label overrides per type

Bastien Lutz CR +2 V +2 Normal +86 −0 updated 07/27/26, 14:29

Commit message

It is possible to override TCA field labels on a
per-type basis using page TSconfig.

A change in the dependency order of
FormDataProviders caused the
TcaColumnsProcessFieldLabels provider to execute
before the PageTsConfigMerged provider.
Since the label overrides also rely on the merged
page TSconfig, they were not applied.

Fix this by ensuring PageTsConfigMerged is always
executed before TcaColumnsProcessFieldLabels.

Also provide a new functional `FormDataProviderTest`
that runs through the FormDataCompiler pass with
a fully bootstrapped `tcaDatabaseRecord` array of
FormDataProviders.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Simon Schaufelberger +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 912

  1. Bastien Lutz uploaded patch set 1 06/15/26, 13:24

  2. core-ci voted on patch set 1 V -1 06/15/26, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103520

  3. Bastien Lutz rebased onto patch set 2 V -1 06/16/26, 06:16

  4. core-ci voted on patch set 2 V +1 06/16/26, 06:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103545

  5. Garvin Hicking commented on patch set 2 CR -1 06/26/26, 14:18

    On it. I'm in the progress of wiring up a functional test for the formDataCompiler, I think it would be worthwile to allow executing the whole chain and test for the label processing specifically. That would allow us in the future to pin more tests on this to prevent regressions. Hope that's fine with you.
  6. Garvin Hicking uploaded patch set 3 CR -1 V +1 06/26/26, 14:24

  7. Garvin Hicking commented on patch set 3 CR +1 V +1 06/26/26, 14:25

    done
  8. core-ci voted on patch set 3 V +1 06/26/26, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103950

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 07/10/26, 20:50

  10. Benni Mack voted on patch set 3 CR +1 V +1 07/27/26, 13:52

  11. Garvin Hicking voted on patch set 3 CR +2 V +2 07/27/26, 14:05

  12. Garvin Hicking merged patch set 4 07/27/26, 14:29