Review 12.4 Work in progress Stale

94512[WIP][BUGFIX] Use parent page id in extbase for `pid` relation to pages

Stefan Bürk CR 0 V 0 Easy +11 −1 updated 06/15/26, 15:10

Commit message

In case of configured group relation for a record table `pid`
field, for example like:

    'pid' => [
        'label' => 'Record Storage PID',
        'config' => [
            'type' => 'group',
            'allowed' => 'pages',
            'foreign_table' => 'pages',
        ],
    ],

extbase uses a hardcoded zero `(int)0` for the `pid` value
in the `Backend::insertObject()` setting that back to the
object and always saving these records on `pid=0` even if
a custom `pid` value has been provided with a related page
record uid.

This change introduces a speceial `pid` treatment for that
case ensure to use the related record uid as `pid` and now
persisting the record on expected page.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/94512/1 && git checkout FETCH_HEAD
Cherry-pick onto 12.4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/94512/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Files 1

Review log 12

  1. Stefan Bürk uploaded patch set 1 06/15/26, 15:04

  2. core-ci voted on patch set 1 V +1 06/15/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103526