Review 13.4 Abandoned

94515[BUGFIX] Fix TypeError when importing relation via DataHandler

Benjamin Franzke CR 0 V 0 Easy +4 −2 updated 10/18/26, 07:23

Commit message

Relations (like sys_file_reference when importing EXT:introduction in
v13) may not provide a `pid` value and therefore triggered
a PHP warning and a type error, because `$theRealPid` was
assigned a null value.

Skip the site-resolution, in this case, since the method itself
is meant to skip operation anyway, incase no site could be found.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 3

Files 1

Review log 34

  1. Benjamin Franzke uploaded patch set 1 06/16/26, 08:18

  2. core-ci voted on patch set 1 V +1 06/16/26, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103548

  3. Benjamin Franzke marked it work in progress 06/19/26, 08:54

  4. Benni Mack abandoned the change 10/18/26, 07:23

    abandoning the change - see the issues resolved differently.