Review main Merged

94521[BUGFIX] List `extension:activate` in list of possible commands

Benjamin Franzke CR +2 V +2 Normal +61 −6 updated 06/29/26, 09:36

Commit message

The list of commands was supposed to skip `extension:activate`
and `extension:deactivate` in composer mode since #94996,
while they should remain visible in classic mode, which fails
for two reasons:

 * The string-based env-expressions – that is
   `hidden: '%env(TYPO3:isComposerMode)%'` in
   `extensionmanager/Configuration/Services.yaml`
   were casted to `bool` by the console command pass, therefore
   they were never evaluated by the symfony `PhpDumper`
   (which operates after the execution of the compiler passes)
 * The expression used an invalid "is" prefix, that was
   implemented differently than it was documented in #89764.
   It implemented support for `%env(TYPO3:composerMode)%`
   but documented `%env(TYPO3:isComposerMode)%`.

We now remove the invalid bool cast and adapt the
env-placeholder implementation to support
the documented behavior, while keeping the
prior implementation intact.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1114

  1. Benjamin Franzke uploaded patch set 1 06/16/26, 11:53

  2. core-ci voted on patch set 1 V +1 06/16/26, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103566

  3. Benjamin Franzke uploaded patch set 2 V +1 06/16/26, 12:54

  4. core-ci voted on patch set 2 V +1 06/16/26, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103571

  5. Andreas Kienast voted on patch set 2 CR +1 06/16/26, 13:48

  6. Andreas Kienast voted on patch set 2 V +1 06/26/26, 09:21

  7. Garvin Hicking commented on patch set 2 CR +1 V +1 06/26/26, 17:50

    Minor spelling comments in the commit body that shouldn't block voting. Just in case there's any need to rebase or repush this, it could be addressed.
    ```suggestion they were never evaluated by the symfony `PhpDumper` ```
    ```suggestion * The expression used an invalid "is" prefix, that was ```
    ```suggestion but documented `%env(TYPO3:isComposerMode)%`. ```
  8. Benjamin Franzke rebased onto patch set 3 CR +1 V +1 06/29/26, 07:32

  9. Benjamin Franzke commented on patch set 3 06/29/26, 07:32

    Reply

    Thx a lot 🙈, fixed.

    Reply

    Done

    Reply

    Done

    Reply

    Done
  10. Andreas Kienast voted on patch set 3 CR +1 V +1 06/29/26, 07:35

  11. core-ci voted on patch set 3 V +1 06/29/26, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104012

  12. Garvin Hicking voted on patch set 3 CR +1 V +1 06/29/26, 09:33

  13. Benjamin Franzke voted on patch set 3 CR +2 V +2 06/29/26, 09:36

  14. Benjamin Franzke merged patch set 4 06/29/26, 09:36