Review main Merged

94522[BUGFIX] Add proper type annotation for DataHandling->errorLog

Daniel Siepmann CR +2 V +2 Easy +2 −0 updated 06/18/26, 09:42

Commit message

In order to get rid of PHPStan issues in consuming code.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Markus Klein +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Markus Klein +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1519

  1. Daniel Siepmann uploaded patch set 1 06/17/26, 06:20

  2. Daniel Siepmann uploaded patch set 2 06/17/26, 06:22

  3. core-ci voted on patch set 1 V -1 06/17/26, 06:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103596

  4. core-ci voted on patch set 2 V +1 06/17/26, 06:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103597

  5. Oliver Klee updated the commit message in patch set 3 V +1 06/17/26, 08:07

  6. Oliver Klee voted on patch set 3 CR +1 V +1 06/17/26, 08:07

  7. core-ci voted on patch set 3 V +1 06/17/26, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103602

  8. Matthias Vogel voted on patch set 3 CR +1 V +1 06/17/26, 08:24

  9. Markus Klein voted on patch set 3 CR +1 V +1 06/18/26, 07:10

  10. Oliver Hader commented on patch set 3 06/18/26, 07:52

    DataHandler.php:221

    Should it be `list<string>` instead (which is even more specific)?
  11. Markus Klein commented on patch set 3 06/18/26, 07:59

    DataHandler.php:221 Reply

    Then I'd go for `list<non-empty-string>`
  12. Oliver Klee commented on patch set 4 CR +1 V +1 06/18/26, 08:45

    Published edit on patch set 3.
  13. Oliver Klee commented on patch set 4 CR +1 V +1 06/18/26, 08:46

    DataHandler.php:221 Reply

    Done
  14. Simon Schaufelberger voted on patch set 4 CR +1 V +1 06/18/26, 08:52

  15. core-ci voted on patch set 4 V +1 06/18/26, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103633

  16. Matthias Vogel voted on patch set 4 CR +1 V +1 06/18/26, 09:21

  17. Markus Klein voted on patch set 4 CR +1 V +1 06/18/26, 09:27

  18. Oliver Hader commented on patch set 4 CR +2 V +2 06/18/26, 09:41

    Thx!
  19. Oliver Hader merged patch set 5 06/18/26, 09:42