Review 13.4 Merged

94529[BUGFIX] Properly backport avoid using null as array offset

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 06/22/26, 07:25

Commit message

The patch in #109461 addressed several PHP 8.5 related array
check strictnesses.

The backport of that patch to 13.4 failed proper merge conflict
resolving and thus missed backporting one instance of
an array check in the `BackendUtility::getModuleData` method.

This change is in effect in main and 14.3, and now put into
13.4 to allow using PHP 8.5 without exceptions.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Markus Klein +1
    • Josua Vogel +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Markus Klein +1
    • Josua Vogel +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 78

  1. Garvin Hicking uploaded patch set 1 06/18/26, 17:44

  2. Markus Klein voted on patch set 1 CR +1 V +1 06/18/26, 17:47

  3. core-ci voted on patch set 1 V +1 06/18/26, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103640

  4. Oliver Klee voted on patch set 1 CR +1 V +1 06/18/26, 19:23

  5. Josua Vogel voted on patch set 1 CR +1 V +1 06/22/26, 06:52

  6. Oliver Hader voted on patch set 1 CR +1 V +1 06/22/26, 07:01

  7. Garvin Hicking commented on patch set 1 CR +2 V +2 06/22/26, 07:25

    thanks, and sorry for my mishap
  8. Garvin Hicking merged patch set 2 06/22/26, 07:25