94530[BUGFIX] Guard undefined array key in ImageProcessingInstructions
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Oliver Hader +1
- Ravi Sachaniya +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Oliver Hader +1
- Ravi Sachaniya +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1213
-
Garvin Hicking uploaded patch set 1 06/18/26, 18:00
-
core-ci voted on patch set 1 V +1 06/18/26, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103641
-
Oliver Klee voted on patch set 1 CR +1 V +1 06/18/26, 19:24
-
Ravi Sachaniya voted on patch set 1 CR +1 V +1 06/22/26, 05:32
-
Simon Schaufelberger voted on patch set 1 CR +1 V +1 06/22/26, 08:32
-
Oliver Hader commented on patch set 1 V +1 06/22/26, 10:55
-
Garvin Hicking commented on patch set 1 06/22/26, 11:14
ImageProcessingInstructions.php:326ReplyThe problem there is the indentation of it - I need a dedicated upper-level "unset(...)" one without the json_decode on top of it. Otherwise the later "insteanceof Area" would be non-matching and then I'd have an additional "else" branch at the end. So I figured an explicit "else" at the top would be more readable. -
Oliver Hader commented on patch set 1 CR +1 06/22/26, 11:48
ImageProcessingInstructions.php:326ReplyIn any way, the code reads fine... -
Garvin Hicking commented on patch set 1 CR +2 V +2 06/22/26, 14:07
thx! 😊 -
Garvin Hicking merged patch set 2 06/22/26, 14:19
-
Benjamin Franzke commented on patch set 2 06/25/26, 10:36
@garvin@hick.ing Can you explain why https://forge.typo3.org/issues/103351 is related? Did it introduce the problem? (It seems the json_encode/explode existed before) -
Garvin Hicking commented on patch set 2 06/25/26, 11:05
Reply
The relation to 103351 was just because in that patch the cropping values were also sanitized, but not completely. I have not checked whether the bug was introduced there - I only saw that the cropping calculations in there was unified and centralized there, and so I related it as a "hint, hint - look at why this was already once refactored". -
Garvin Hicking commented on patch set 2 06/26/26, 11:50
Please note a late-backport to 13.4 was also made.
ImageProcessingInstructions.php:326