Review 13.4 Merged

94533[BUGFIX] Properly require symfony/polyfill-php84 and php85

Garvin Hicking CR +2 V +2 Normal +165 −81 updated 06/19/26, 08:59

Commit message

A change in #108346 introduced the usage of `array_find`,
which is PHP 8.4 functionality. TYPO3 13+ currently has a
PHP 8.2 compatibility.

For core development and testing, the dev dependencies
included `symfony/polyfill-php84` as a transient dependency,
so tests running PHP 8.2 did not pick up that a polyfill
was actually used which is not bundled inside the TYPO3
release package.

This patch now declares these dependencies specifically
to prevent future trouble.

Executed commands:

```
Build/Scripts/runTests.sh -s composer req symfony/polyfill-php85 \
  -d typo3/sysext/core --no-update
Build/Scripts/runTests.sh -s composer req symfony/polyfill-php84 \
  -d typo3/sysext/core --no-update
Build/Scripts/runTests.sh -s composer req -w symfony/polyfill-php84
Build/Scripts/runTests.sh -s composer req -w symfony/polyfill-php85
```

(This might be a hint for us to rethink how we execute
static code analysis and probably should not rely on
"composer install" with dev dependencies, which currently
is needed to even have PHPStan and friends to be executed.)

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 68

  1. Garvin Hicking commented on patch set 1 06/19/26, 07:04

    Cherry Picked from branch main. The following files contain Git conflicts: * composer.json * composer.lock * typo3/sysext/core/composer.json
  2. core-ci voted on patch set 1 V -1 06/19/26, 07:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103661

  3. Garvin Hicking uploaded patch set 2 V -1 06/19/26, 07:10

    adapt backport
  4. Garvin Hicking marked it ready for review 06/19/26, 07:10

  5. core-ci voted on patch set 2 V +1 06/19/26, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103664

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 06/19/26, 08:39

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 06/19/26, 08:59

  8. Garvin Hicking merged patch set 3 06/19/26, 08:59