Review main Merged

94538[BUGFIX] Drop title tooltips from file reference headers

Christian Rath-Ulrich CR +2 V +2 Easy +13 −4 updated 10/23/26, 17:53

Commit message

The thumbnail in a file reference header is decorative. The toggle
button already shows the record title, so a title tooltip repeats
that text and conflicts with the empty alt attribute.

Keep alt="" on the thumbnail and remove its title. Drop the title
from the fallback icon for the same reason.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Christian Rath-Ulrich uploaded patch set 1 06/22/26, 08:58

  2. core-ci voted on patch set 1 V +1 06/22/26, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103730

  3. Benni Mack uploaded patch set 2 V +1 10/02/26, 09:54

  4. Benni Mack updated the commit message in patch set 3 10/02/26, 09:54

  5. Benni Mack commented on patch set 3 CR -1 10/02/26, 09:55

    I agree that having both alt="" and a title tooltip gives mixed signals, and the tooltip on the thumbnail isn't useful. But how about: Keep alt="" on the thumbnail, drop its title, and add nothing else. Optionally do the same for the fallback icon's title. What do yo uthink?
  6. core-ci voted on patch set 3 V +1 10/02/26, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109899

  7. core-ci voted on patch set 2 V +1 10/02/26, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109898

  8. Christian Rath-Ulrich uploaded patch set 4 CR -1 V +1 10/22/26, 15:00

  9. Christian Rath-Ulrich commented on patch set 4 10/22/26, 15:01

    Reply

    Done
  10. core-ci voted on patch set 4 V +1 10/22/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112123

  11. Simon Schaufelberger voted on patch set 4 CR +1 V +1 10/22/26, 18:57

  12. Wouter Wolters voted on patch set 4 CR +1 V +1 10/22/26, 19:04

  13. Matthias Vogel voted on patch set 4 CR +1 V +1 10/22/26, 19:27

  14. Georg Ringer voted on patch set 4 CR +2 V +2 10/23/26, 14:14

  15. Georg Ringer merged patch set 5 10/23/26, 17:53