Review 13.4 Merged

94557[BUGFIX] Allow adding entries to an empty settings stringlist

Garvin Hicking CR +2 V +2 Normal +98 −1 updated 06/23/26, 17:39

Commit message

The Site Settings editor renders the add (+) and remove (-)
buttons as part of each stringlist row. When the value list
is empty, because no default is declared or all entries were
removed, the editor exposes no control to add a first entry
and the user is stuck. The outer <label for="..."> also loses
its target input, breaking click-to-focus and accessibility.

Exposes a +-button when an empty list is provided, to
allow adding entries in this case.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Garvin Hicking commented on patch set 1 06/23/26, 15:11

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/23/26, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103774

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 06/23/26, 17:39

  4. Garvin Hicking merged patch set 2 06/23/26, 17:39