Review main Merged

94558[TASK] Promote generateRandomBase64String to public API

Oliver Hader CR +2 V +2 Normal +59 −51 updated 06/24/26, 12:10

Commit message

Use generateRandomBase64String instead of hex-encoding in
DataHandler's correlation ID generation: base64url yields
~33% more entropy per character than hex, so a 32-char
token covers 192 bits rather than 128 bits.

Promotes the method from protected to public to allow
callers outside the class to benefit from the same
higher-entropy token generation.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 79

  1. Oliver Hader uploaded patch set 1 06/24/26, 06:54

  2. core-ci voted on patch set 1 V +1 06/24/26, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103788

  3. Oliver Hader uploaded patch set 2 V +1 06/24/26, 07:06

  4. core-ci voted on patch set 2 V +1 06/24/26, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103789

  5. Oliver Klee voted on patch set 2 CR +1 V +1 06/24/26, 08:03

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 06/24/26, 09:19

  7. Georg Ringer voted on patch set 2 CR +1 V +1 06/24/26, 11:08

  8. Oliver Hader voted on patch set 2 CR +2 V +2 06/24/26, 12:10

  9. Oliver Hader merged patch set 3 06/24/26, 12:10