Review main Merged

94559[BUGFIX] Fix initial EXT:introduction database import on sqlite

Benjamin Franzke CR +2 V +2 Easy +26 −1 updated 06/27/26, 17:49

Commit message

The EXT:introduction distribution failed to import on sqlite,
because the database could not be updated properly, causing
SQL errors due to missing fields and later PHP errors (which
will be handled separately, see #110060) due to missing parent-rows
during the impexp execution.

This happened because the installation of EXT:bootstrap_package will
cause one existing column to be changed and new ones to be added.

When database columns are being changed and added,
the doctrine sqlite platform will create a temporary database
schema (based on the current schema) for the changed
columns, since `ALTER TABLE` does only allow to add new
columns.

Now, if there are columns to be added and columns to be changed,
the `ALTER TABLE … ADD COLUMN` statement was executed first,
while the sqlite table recreation pattern (based on the old scheme)
was applied afterwards, effectively reverting the aformentioned
`ADD COLUMN` instructions.

To overcome this issue, the ordering is adapted to ensure that
`ADD` instructions are executed last. This is now covered by a
functional test.

Note: The change of the existing column (tsconfig_includes) when
installing EXT:bootstrap_package as dependency of EXT:introduction
is actually not intended, but happened because
`ExtensionManagementUtility::registerPageTSConfigFile()`
causes the autogenerated database schema to be changed. This is
the trigger that revealed this error, and will be handled
separately in #110091.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1219

  1. Benjamin Franzke commented on patch set 1 06/24/26, 07:34

    Cherry Picked from branch 13.4.
  2. core-ci voted on patch set 1 V +1 06/24/26, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103792

  3. Benjamin Franzke commented on patch set 1 06/24/26, 08:04

    SchemaMigratorTest.php:427

    Please see > 94560: [TEST] Test for #110061 | https://review.typo3.org/c/Packages/TYPO3.CMS/+/94560 > https://git.typo3.org/typo3/CI/cms/-/pipelines/103794 for a test run where this test fails (without the fix applied), but only for sqlite.
  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 06/24/26, 09:22

  5. Andreas Kienast commented on patch set 1 CR -1 06/26/26, 09:18

    Did you mean #110060?
  6. Benjamin Franzke updated the commit message in patch set 2 CR +1 V +1 06/26/26, 11:39

  7. Benjamin Franzke commented on patch set 2 06/26/26, 11:39

    Reply

    Yes, right. Thx!
  8. core-ci voted on patch set 2 V -1 06/26/26, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103940

  9. Garvin Hicking updated the commit message in patch set 3 V -1 06/26/26, 17:43

  10. Garvin Hicking voted on patch set 3 CR +1 V +1 06/26/26, 17:43

  11. core-ci voted on patch set 3 V -1 06/26/26, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103957

  12. core-ci commented on patch set 3 06/26/26, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103957

  13. core-ci commented on patch set 3 06/26/26, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103957

  14. core-ci commented on patch set 3 06/26/26, 22:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103957

  15. core-ci voted on patch set 3 V +1 06/26/26, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103957

  16. Simon Schaufelberger voted on patch set 3 CR +1 V +1 06/27/26, 00:40

  17. Oliver Klee voted on patch set 3 CR +1 V +1 06/27/26, 07:55

  18. Benjamin Franzke voted on patch set 3 CR +2 V +2 06/27/26, 10:46

  19. Garvin Hicking merged patch set 4 06/27/26, 17:49