Review main Merged

94561[BUGFIX] Drop redundant .bind(this) on arrow field cropMoveHandler

Oliver Hader CR +2 V +2 Easy +2 −2 updated 07/01/26, 07:38

Commit message

ImageManipulation.cropMoveHandler already uses an arrow function
which binds to the instance at creation time. Using and additional
.bind(this) wrapper for the function reference is superfluous.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Oliver Hader uploaded patch set 1 06/24/26, 09:49

  2. core-ci voted on patch set 1 V -1 06/24/26, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103800

  3. Oliver Hader uploaded patch set 2 V -1 06/27/26, 19:31

  4. Oliver Hader commented on patch set 2 06/27/26, 19:31

    Oops, I forgot to commit the compiled JS file.
  5. core-ci voted on patch set 2 V +1 06/27/26, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103977

  6. Andreas Kienast voted on patch set 2 CR +1 06/29/26, 05:54

  7. Benjamin Franzke voted on patch set 2 CR +1 V +1 06/29/26, 07:27

  8. Oliver Klee voted on patch set 2 CR +1 06/30/26, 10:28

  9. Simon Schaufelberger voted on patch set 2 CR +1 V +1 06/30/26, 12:08

  10. Benjamin Franzke voted on patch set 2 CR +2 V +2 07/01/26, 06:55

  11. Benjamin Franzke merged patch set 3 07/01/26, 07:38