94562[BUGFIX] Avoid endless recursion in workspace dependencies
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/workspaces/Classes/Dependency/ElementEntity.php+27 −7
- typo3/sysext/workspaces/Classes/Service/Dependency/CollectionService.php+45 −9
- typo3/sysext/workspaces/Tests/Functional/Dependency/Fixtures/CircularDependencies.csvnew+32 −0
- typo3/sysext/workspaces/Tests/Functional/Dependency/CircularDependencyTest.phpnew+172 −0
- typo3/sysext/workspaces/Tests/Unit/Service/Dependency/CollectionServiceTest.phpnew+145 −0
Review log 1520
-
Philipp Kitzberger uploaded patch set 1 06/24/26, 09:52
-
core-ci voted on patch set 1 V -1 06/24/26, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103801
-
Philipp Kitzberger uploaded patch set 2
V -106/24/26, 10:08 -
core-ci voted on patch set 2 V +1 06/24/26, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103803
-
Oliver Klee voted on patch set 2 V +1 07/03/26, 12:35
-
Oliver Klee commented on patch set 2 07/03/26, 16:21
Are 14.3 and 13.4 affected as well? (Haven't checked.) -
Philipp Kitzberger commented on patch set 2 07/06/26, 07:05
Reply
Yes, they are! Should I add those version numbers as well? -
Oliver Klee updated the commit message in patch set 3
V +107/06/26, 10:00 -
Oliver Klee commented on patch set 3 V +1 07/06/26, 10:01
Reply
I've added them now. -
core-ci voted on patch set 3 V +1 07/06/26, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104395
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 07/07/26, 00:21
-
Benni Mack uploaded patch set 4
CR +1V +109/02/26, 14:52 -
core-ci voted on patch set 4 V +1 09/02/26, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107643
-
Benni Mack updated the commit message in patch set 5
V +109/02/26, 15:00 -
Benni Mack voted on patch set 5 CR +1 V +1 09/02/26, 15:00
-
core-ci voted on patch set 5 V +1 09/02/26, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107644
-
Oliver Klee voted on patch set 5 V +1 09/02/26, 15:10
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 09/02/26, 15:50
-
Benni Mack voted on patch set 5 CR +2 V +2 09/02/26, 16:01
-
Benni Mack merged patch set 6 09/02/26, 16:01