Review 13.4 Merged

94564[TASK] Promote generateRandomBase64String to public API

Oliver Hader CR +2 V +2 Normal +59 −51 updated 06/24/26, 12:10

Commit message

Use generateRandomBase64String instead of hex-encoding in
DataHandler's correlation ID generation: base64url yields
~33% more entropy per character than hex, so a 32-char
token covers 192 bits rather than 128 bits.

Promotes the method from protected to public to allow
callers outside the class to benefit from the same
higher-entropy token generation.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Oliver Hader uploaded patch set 1 06/24/26, 11:33

  2. core-ci voted on patch set 1 V +1 06/24/26, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103808

  3. Oliver Hader voted on patch set 1 CR +2 V +2 06/24/26, 12:10

  4. Oliver Hader merged patch set 2 06/24/26, 12:10