Review 14.3 Merged

94566[BUGFIX] Consider all workspace-enabled tables for stage buttons

Oli Bartsch CR +2 V +2 Easy +2 −8 updated 07/02/26, 11:36

Commit message

The workspace preview stage buttons (next/previous) only considered
records from 'pages' and 'tt_content' tables when calculating which
stage actions to show. This caused the buttons to not appear or work
incorrectly when workspace changes existed only in other tables
(e.g., custom extension tables with workspace support).

This limitation dates back to the original implementation in commit
fd976603f98 from 2011.

The methods getPreviousStageForElementCollection()
and getNextStageForElementCollection() were designed with a
configurable $byTableName parameter that defaulted to
['tt_content', 'pages', 'pages_language_overlay'].

However, the callers (PreviewController, ActionHandler) never passed
this parameter, always using the default. Over time, through various
refactorings, the parameter was removed entirely and the table
restriction became hardcoded.

Since the $workspaceItems array passed to these methods already
contains only records from workspace-enabled tables that the user
has permission to modify (filtered by selectVersionsInWorkspace()
with 'tables_modify'), the additional table filtering is unnecessary
and actively harmful.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oli Bartsch commented on patch set 1 06/24/26, 12:03

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/24/26, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103812

  3. Georg Ringer voted on patch set 1 CR +1 V +1 07/01/26, 20:18

  4. Benni Mack voted on patch set 1 CR +2 V +2 07/02/26, 11:36

  5. Benni Mack merged patch set 2 07/02/26, 11:36