Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
94572[TASK] Resolve EXT:form variants lazily per step
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 13
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/72/94572/13 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/72/94572/13 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 2
Files 16
- typo3/sysext/core/Documentation/Changelog/15.0/Important-110099-LazyVariantResolution.rstnew+73 −0
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractFormElement.php+32 −17
- typo3/sysext/form/Classes/Domain/Model/Renderable/Variant/VariantContext.phpnew+56 −0
- typo3/sysext/form/Classes/Domain/Model/Renderable/Variant/VariantOptionResolver.phpnew+125 −0
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+127 −32
- typo3/sysext/form/Classes/Domain/Model/Renderable/RenderableVariant.php+77 −14
- typo3/sysext/form/Classes/Domain/Model/Renderable/RenderableVariantInterface.php+27 −8
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+31 −0
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+44 −19
- typo3/sysext/form/Classes/Mvc/ProcessingRule.php+57 −31
- typo3/sysext/form/Documentation/I/Concepts/Variants/Index.rst+5 −3
- typo3/sysext/form/Tests/Functional/Domain/Model/Renderable/Variant/LazyVariantResolutionTest.phpnew+268 −0
- typo3/sysext/form/Tests/Functional/Domain/Runtime/FormRuntimeTest.php+121 −6
- typo3/sysext/form/Tests/Unit/Domain/Model/Renderable/Variant/VariantOptionResolverTest.phpnew+102 −0
- typo3/sysext/form/Tests/Unit/Domain/Renderable/RenderableVariantTest.php+12 −5
- typo3/sysext/form/Tests/Unit/Mvc/ProcessingRuleTest.php+74 −0
Review log 1629
Show 34 earlier messages
-
Josua Vogel uploaded patch set 1 06/24/26, 15:43
-
Josua Vogel marked it work in progress 06/24/26, 15:43
-
Josua Vogel uploaded patch set 2 06/24/26, 15:48
-
core-ci voted on patch set 1 V -1 06/24/26, 15:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103824
-
core-ci voted on patch set 2 V +1 06/24/26, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103825
-
Josua Vogel uploaded patch set 3
V +106/24/26, 16:20 -
core-ci voted on patch set 3 V +1 06/24/26, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103826
-
Josua Vogel uploaded patch set 4
V +106/24/26, 18:57 -
core-ci voted on patch set 4 V -1 06/24/26, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103829
-
Josua Vogel uploaded patch set 5
V -106/24/26, 19:06 -
Josua Vogel uploaded patch set 6 06/24/26, 19:07
-
core-ci voted on patch set 6 V -1 06/24/26, 19:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103831
-
core-ci voted on patch set 5 V -1 06/24/26, 19:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103830
-
Josua Vogel uploaded patch set 7
V -106/24/26, 19:35 -
core-ci voted on patch set 7 V -1 06/24/26, 19:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103832
-
Josua Vogel uploaded patch set 8
V -106/24/26, 20:41 -
core-ci voted on patch set 8 V -1 06/24/26, 20:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103833
-
Josua Vogel uploaded patch set 9
V -106/24/26, 20:58 -
core-ci voted on patch set 9 V +1 06/24/26, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103834
-
Josua Vogel marked it ready for review 06/24/26, 21:09
-
Josua Vogel rebased onto patch set 10
V +107/03/26, 17:02 -
core-ci voted on patch set 10 V +1 07/03/26, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104320
-
Josua Vogel uploaded patch set 11
V +109/24/26, 15:25 -
core-ci voted on patch set 11 V -1 09/24/26, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109169
-
Josua Vogel uploaded patch set 12
V -109/24/26, 15:49 -
core-ci voted on patch set 12 V -1 09/24/26, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109172
-
Josua Vogel uploaded patch set 13
V -109/25/26, 06:33 -
core-ci voted on patch set 13 V +1 09/25/26, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109223
-
Lina Wolf commented on patch set 13 10/15/26, 11:04
The form manual on main was re-indented in https://review.typo3.org/c/Packages/TYPO3.CMS/+/96702 (two spaces after "..", 4-space levels, headline levels). This change will probably conflict in typo3/sysext/form/Documentation when rebased. The script used for the conversion can help to bring new text into the same format; ask me if you need it.