94573[BUGFIX] Refine exceptions to root-level restriction in DataHandler
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oliver Hader +2
- Oliver Klee +1
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/DataHandling/DataHandler.php4+59 −51
- typo3/sysext/core/Classes/Type/VirtualRecord.php3new+34 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesModify/DataSet/modifyFileMetadataAsNonAdminEditor.csvnew+27 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesModify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/AbstractActionTestCase.php+1 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/AbstractActionWorkspacesTestCase.php2+7 −0
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+9 −5
Review log 2333
Show 78 earlier messages
-
Oliver Hader uploaded patch set 1 06/24/26, 18:17
-
Oliver Hader commented on patch set 1 06/24/26, 18:19
-
Oliver Hader commented on patch set 1 06/24/26, 18:23
DataHandler.php:7648`@param string $table` -
core-ci voted on patch set 1 V -1 06/24/26, 19:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103827
-
Oliver Hader uploaded patch set 2
V -106/25/26, 11:52 -
Oliver Hader commented on patch set 2 06/25/26, 11:53
DataHandler.php:7648ReplyDoneDataHandler.php:7656That's wrong -
Oliver Hader commented on patch set 2 06/25/26, 11:54
Tests shall be extracted to a separate patch - and probably, I'll only use it for the particular test case to avoid having to update all reference indexes.DataHandler.php:7656ReplyDone -
Oliver Hader rebased onto patch set 3 06/25/26, 12:03
-
core-ci voted on patch set 2 V -1 06/25/26, 12:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103874
-
Oliver Hader commented on patch set 3 06/25/26, 12:10
AbstractActionWorkspacesTestCase.php:155ReplyDone -
core-ci voted on patch set 3 V -1 06/25/26, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103876
-
Oliver Hader uploaded patch set 4
V -106/25/26, 12:42 -
core-ci voted on patch set 4 V +1 06/25/26, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103880
-
Oliver Hader rebased onto patch set 5
V +106/26/26, 11:39 -
core-ci voted on patch set 5 V -1 06/26/26, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103941
-
Garvin Hicking marked it ready for review 06/26/26, 17:10
-
Oliver Hader commented on patch set 5 06/26/26, 18:20
VirtualRecord.php:28I think, the enum should be internal -
core-ci commented on patch set 5 06/26/26, 18:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103941
-
core-ci commented on patch set 5 06/26/26, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103941
-
core-ci commented on patch set 5 06/26/26, 18:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103941
-
Garvin Hicking commented on patch set 5 06/26/26, 19:23
VirtualRecord.php:28ReplyI mean it's just a "tag". But yeah if we want to refactor this I agree. -
core-ci voted on patch set 5 V +1 06/27/26, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103941
-
Oliver Klee voted on patch set 5 V +1 06/27/26, 13:10
-
Oliver Hader uploaded patch set 6
V +106/28/26, 06:43 -
core-ci voted on patch set 6 V +1 06/28/26, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103990
-
Oliver Klee voted on patch set 6 V +1 06/28/26, 08:08
-
Oliver Hader commented on patch set 6 06/28/26, 08:41
VirtualRecord.php:28ReplyDone -
Garvin Hicking commented on patch set 6 CR +1 06/28/26, 13:38
Will try to test our cases tomorrow -
Garvin Hicking commented on patch set 6 07/03/26, 15:47
I'm sorry, I was not able to test this in real life yet. Not blocking for anyone else who can.... -
Simon Schaufelberger voted on patch set 6 CR +1 V +1 07/07/26, 00:19
-
Garvin Hicking commented on patch set 6 V +1 07/07/26, 20:30
I was finally able to test this and could also properly verify it (hint: don't be an admin user in your non-live workspace...). It goes a bit deep, but I think it's well worth it to boil this down, especially for future and follow-up regressions in this area. -
Oliver Hader voted on patch set 6 CR +2 V +2 07/14/26, 11:49
-
Oliver Hader merged patch set 7 07/14/26, 11:50
AbstractActionWorkspacesTestCase.php:155