Review main Merged

94573[BUGFIX] Refine exceptions to root-level restriction in DataHandler

Oliver Hader CR +2 V +2 Normal +144 −56 updated 07/14/26, 11:50

Commit message

An alternative approach is to make the root-level invocation more
explicit instead of repeatedly inferring it.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 2333

Show 78 earlier messages
  1. Oliver Hader uploaded patch set 1 06/24/26, 18:17

  2. Oliver Hader commented on patch set 1 06/24/26, 18:19

    AbstractActionWorkspacesTestCase.php:155

    The test were created by Claude Code. I'm not happy yet, since editing by editors should be more central and not be tweaked for a specific test case.
  3. Oliver Hader commented on patch set 1 06/24/26, 18:23

    DataHandler.php:7648

    `@param string $table`
  4. core-ci voted on patch set 1 V -1 06/24/26, 19:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103827

  5. Oliver Hader uploaded patch set 2 V -1 06/25/26, 11:52

  6. Oliver Hader commented on patch set 2 06/25/26, 11:53

    DataHandler.php:7648 Reply

    Done

    DataHandler.php:7656

    That's wrong
  7. Oliver Hader commented on patch set 2 06/25/26, 11:54

    Tests shall be extracted to a separate patch - and probably, I'll only use it for the particular test case to avoid having to update all reference indexes.

    DataHandler.php:7656 Reply

    Done
  8. Oliver Hader rebased onto patch set 3 06/25/26, 12:03

  1. core-ci voted on patch set 2 V -1 06/25/26, 12:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103874

  2. Oliver Hader commented on patch set 3 06/25/26, 12:10

    AbstractActionWorkspacesTestCase.php:155 Reply

    Done
  3. core-ci voted on patch set 3 V -1 06/25/26, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103876

  4. Oliver Hader uploaded patch set 4 V -1 06/25/26, 12:42

  5. core-ci voted on patch set 4 V +1 06/25/26, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103880

  6. Oliver Hader rebased onto patch set 5 V +1 06/26/26, 11:39

  7. core-ci voted on patch set 5 V -1 06/26/26, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103941

  8. Garvin Hicking marked it ready for review 06/26/26, 17:10

  9. Oliver Hader commented on patch set 5 06/26/26, 18:20

    VirtualRecord.php:28

    I think, the enum should be internal
  10. core-ci commented on patch set 5 06/26/26, 18:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103941

  11. core-ci commented on patch set 5 06/26/26, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103941

  12. core-ci commented on patch set 5 06/26/26, 18:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103941

  13. Garvin Hicking commented on patch set 5 06/26/26, 19:23

    VirtualRecord.php:28 Reply

    I mean it's just a "tag". But yeah if we want to refactor this I agree.
  14. core-ci voted on patch set 5 V +1 06/27/26, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103941

  15. Oliver Klee voted on patch set 5 V +1 06/27/26, 13:10

  16. Oliver Hader uploaded patch set 6 V +1 06/28/26, 06:43

  17. core-ci voted on patch set 6 V +1 06/28/26, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103990

  18. Oliver Klee voted on patch set 6 V +1 06/28/26, 08:08

  19. Oliver Hader commented on patch set 6 06/28/26, 08:41

    VirtualRecord.php:28 Reply

    Done
  20. Garvin Hicking commented on patch set 6 CR +1 06/28/26, 13:38

    Will try to test our cases tomorrow
  21. Garvin Hicking commented on patch set 6 07/03/26, 15:47

    I'm sorry, I was not able to test this in real life yet. Not blocking for anyone else who can....
  22. Simon Schaufelberger voted on patch set 6 CR +1 V +1 07/07/26, 00:19

  23. Garvin Hicking commented on patch set 6 V +1 07/07/26, 20:30

    I was finally able to test this and could also properly verify it (hint: don't be an admin user in your non-live workspace...). It goes a bit deep, but I think it's well worth it to boil this down, especially for future and follow-up regressions in this area.
  24. Oliver Hader voted on patch set 6 CR +2 V +2 07/14/26, 11:49

  25. Oliver Hader merged patch set 7 07/14/26, 11:50