Review main Merged

94574[BUGFIX] Preserve dots in scalar map keys in form editor model

Josua Vogel CR +2 V +2 Easy +23 −10 updated 07/28/26, 14:08

Commit message

Object keys that contain a dot (for example email addresses used as
recipient keys, like `foo@bar.de`) were corrupted when a form element
or finisher was loaded into the backend form editor model.

The model accessor in `core.ts` treats a dot as a structural path
separator. When `extendModel()` descended into a value-to-label map and
called `Model.set('…recipients.foo@bar.de', 'foo bar')`, the key was
split at the dot and turned into a nested object
`{ 'foo@bar': { de: 'foo bar' } }` instead of the intended
`{ 'foo@bar.de': 'foo bar' }`. As a result a predefined recipient was
rendered as two entries in the property grid editor — one correct and
one broken.

A special case already existed for `properties.options`, where such
maps were stored as a whole instead of building per-key dotted paths.
This is now generalized: any object whose values are all scalars
(a "leaf map", e.g. select options or finisher recipients) is stored
as a whole at its path prefix. For dot-free keys the resulting object
structure is identical to before, so there is no behavioral change in
the common case; only keys containing a dot are now preserved intact.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Josua Vogel uploaded patch set 1 06/24/26, 21:38

  2. Josua Vogel updated the commit message in patch set 2 06/24/26, 21:38

  3. core-ci voted on patch set 2 V +1 06/24/26, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103839

  4. core-ci voted on patch set 1 V +1 06/24/26, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103838

  5. Josua Vogel rebased onto patch set 3 V +1 07/26/26, 16:56

  6. core-ci voted on patch set 3 V +1 07/26/26, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105426

  7. Garvin Hicking voted on patch set 3 CR +1 V +1 07/26/26, 19:11

  8. Benni Mack voted on patch set 3 CR +2 V +2 07/28/26, 14:08

  9. Benni Mack merged patch set 4 07/28/26, 14:08