Review main Merged

94582[TASK] Obtain `ConnectionPool` from container in functional tests

Benjamin Franzke CR +2 V +2 Hard +256 −253 updated 06/26/26, 11:22

Commit message

Avoid using `new ConnectionPool()` to prepare for adding
dependencies to the constructor, wired via the
dependency injection container. Therefore all tests are
adapted to obtain the instance from the container and
the `ConnectionPool` unit tests are moved into the functionals
to avoid mocks and to test in a realistic scenario.

For the sake of preventing future cherry-pick conflicts,
the changes are also backported, although not strictly required.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 68

  1. Benjamin Franzke uploaded patch set 1 06/25/26, 09:31

  2. core-ci voted on patch set 1 V +1 06/25/26, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103867

  3. Benjamin Franzke updated the commit message in patch set 2 V +1 06/25/26, 10:24

  4. core-ci voted on patch set 2 V +1 06/25/26, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103870

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 06/26/26, 07:34

  6. Oliver Klee voted on patch set 2 CR +1 V +1 06/26/26, 08:04

  7. Benjamin Franzke voted on patch set 2 CR +2 V +2 06/26/26, 11:21

  8. Benjamin Franzke merged patch set 3 06/26/26, 11:22