Review main Merged

94591[TASK] Add request to ModifyPageLinkConfigurationEvent

Helmut Hummel CR +2 V +2 Easy +10 −2 updated 06/27/26, 07:36

Commit message

A request is required in the buildLink interface method, thus the
request is provided to listeners for modifications of the link.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Helmut Hummel +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Helmut Hummel +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1217

  1. Helmut Hummel uploaded patch set 1 06/26/26, 08:57

  2. Oliver Klee voted on patch set 1 CR +1 06/26/26, 09:16

  3. core-ci voted on patch set 1 V -1 06/26/26, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103929

  4. core-ci commented on patch set 1 06/26/26, 11:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103929

  5. Benjamin Franzke updated the commit message in patch set 2 CR +1 V -1 06/26/26, 11:45

  6. Benjamin Franzke voted on patch set 2 CR +1 V +1 06/26/26, 11:46

  7. Oliver Klee voted on patch set 2 CR +1 V +1 06/26/26, 12:26

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 06/26/26, 12:36

  9. core-ci voted on patch set 2 V -1 06/26/26, 12:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103943

  10. Benjamin Franzke voted on patch set 2 CR +2 V +2 06/26/26, 13:11

  11. core-ci commented on patch set 2 06/26/26, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103943

  12. Oli Bartsch commented on patch set 2 06/26/26, 14:03

    I wonder whether we should somewhere document this new API method?
  13. Garvin Hicking commented on patch set 2 06/26/26, 16:37

    Reply

    IIRC in the docs we usually recommend to checkout the event's method signatures and the auto generated api docs. Since this is IMO a non-vital new argument (that should be there "naturally") I would argue we don't need a changelog entry for it.
  14. Oli Bartsch commented on patch set 2 06/26/26, 17:10

    Reply

    Acknowledged
  15. core-ci voted on patch set 2 V +1 06/27/26, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103943

  16. Helmut Hummel voted on patch set 2 CR +2 V +2 06/27/26, 07:36

  17. Helmut Hummel merged patch set 3 06/27/26, 07:36