94592[TASK] Have playwright helper middleware authenticate requests
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- Josua Vogel +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- Josua Vogel +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1319
-
Garvin Hicking uploaded patch set 1 06/26/26, 10:18
-
Garvin Hicking commented on patch set 1 06/26/26, 10:19
Please note this patch is a continuation of the efforts of lolli, the abandoned patch stays abandoned but the issue is reused. The issue itself needs fixing and was discussed in a meeting. -
core-ci voted on patch set 1 V -1 06/26/26, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103933
-
Garvin Hicking rebased onto patch set 2
V -106/26/26, 11:48 -
core-ci voted on patch set 2 V -1 06/26/26, 12:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103944
-
Benjamin Franzke commented on patch set 2 06/26/26, 13:20
install-tool.ts:10We should make the instance path configurable in order to be able to use playwright on a custom (own) instance, instead of hardcoding paths to the instances that are built by runTests.sh This usecase has been described in the commit message of: > 80557: [TASK] Add accessibility ci tests with playwright/axe | https://review.typo3.org/c/Packages/TYPO3.CMS/+/80557 ``` # Run against local instance ACCESSIBILITY_BASE_URL=https://t3main.devbox.local/typo3 \ npm --prefix=Build run accessibility ``` -
Benjamin Franzke commented on patch set 2 06/26/26, 13:33
install-tool.ts:10ReplyNVM, I see that `readHelperSecret()` reads the `PLAYWRIGHT_HELPER_SECRET` env var. -
Garvin Hicking rebased onto patch set 3
V -106/26/26, 16:33 -
core-ci voted on patch set 3 V -1 06/26/26, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103953
-
core-ci voted on patch set 3 V +1 06/29/26, 05:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103953
-
Oliver Klee voted on patch set 3 V +1 06/29/26, 12:06
-
Garvin Hicking rebased onto patch set 4
V +107/20/26, 11:21 -
core-ci voted on patch set 4 V +1 07/20/26, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105023
-
Oliver Klee voted on patch set 4 V +1 07/27/26, 08:23
-
Benjamin Franzke uploaded patch set 5
V +107/29/26, 05:30 -
core-ci voted on patch set 5 V +1 07/29/26, 05:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105567
-
Josua Vogel voted on patch set 5 CR +1 V +1 07/29/26, 07:03
-
Garvin Hicking voted on patch set 5 CR +2 V +2 07/29/26, 07:26
-
Garvin Hicking merged patch set 6 07/29/26, 07:38