Review 13.4 Merged

94595[TASK] Update npm package dompurify to v3.4.11

Oliver Hader CR +2 V +2 Easy +6 −6 updated 06/26/26, 12:17

Commit message

Executed commands:
cd Build; nvm use; npm ci
npm update dompurify
npm run build-js

None of the known vulnerabilities between the installed version
3.4.5 and 3.4.11 of dompurify is actually used in TYPO3.
Thus, there is no real attack vector in TYPO3:

* https://github.com/advisories/GHSA-x4vx-rjvf-j5p4
  requires `IN_PLACE: true`
  -> not used — not affected
* https://github.com/advisories/GHSA-hpcv-96wg-7vj8
  requires `IN_PLACE: true` (cross-realm)
  -> not used — not affected
* https://github.com/advisories/GHSA-r47g-fvhr-h676
  requires `IN_PLACE: true` (clobbered root)
  -> not used — not affected
* https://github.com/advisories/GHSA-rp9w-3fw7-7cwq
  requires `IN_PLACE: true` + shadow root in @<template>@
  -> not used — not affected
* https://github.com/advisories/GHSA-vxr8-fq34-vvx9
  requires `RETURN_TRUSTED_TYPE` + @clearConfig()@
  -> not used — not affected
* https://github.com/advisories/GHSA-cmwh-pvxp-8882
  requires `setConfig()` for `ALLOWED_ATTR` pollution
  -> not used — not affected
* https://github.com/advisories/GHSA-gvmj-g25r-r7wr
  requires `SAFE_FOR_TEMPLATES` + DOM output mode
  -> not used — not affected
* https://github.com/advisories/GHSA-76mc-f452-cxcm
  requires a hook `data.allowedTags@/@data.allowedAttributes`;
  TYPO3's `afterSanitizeAttributes` hook only calls
  `node.setAttribute('target', '_blank')`
  -> not affected

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 39

  1. Oliver Hader uploaded patch set 1 06/26/26, 10:37

  2. core-ci voted on patch set 1 V -1 06/26/26, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103936

  3. core-ci commented on patch set 1 06/26/26, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103936

  4. core-ci commented on patch set 1 06/26/26, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103936

  5. core-ci commented on patch set 1 06/26/26, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103936

  6. core-ci commented on patch set 1 06/26/26, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103936

  7. core-ci voted on patch set 1 V +1 06/26/26, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103936

  8. Oliver Hader voted on patch set 1 CR +2 V +2 06/26/26, 12:17

  9. Oliver Hader merged patch set 2 06/26/26, 12:17