94596[BUGFIX] Allow expanding inline records in dotted FlexForm fields
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Matthias Vogel +1
-
Verified V +2 Done
- Garvin Hicking +2
- Matthias Vogel +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Form/Container/FileReferenceContainer.php+4 −1
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+4 −1
- typo3/sysext/backend/Tests/Functional/Form/Container/FileReferenceContainerTest.phpnew+95 −0
- typo3/sysext/backend/Tests/Functional/Form/InlineStackProcessorTest.php+24 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_flex.php+8 −0
Review log 1418
-
Georg Ringer uploaded patch set 1 06/26/26, 11:06
-
Georg Ringer commented on patch set 1 06/26/26, 11:06
This change is ready for review. -
core-ci voted on patch set 1 V +1 06/26/26, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103937
-
Garvin Hicking commented on patch set 1 06/26/26, 17:45
InlineStackProcessor.php:216Should this only be done in the `id` case? A dot is fine in `name` attributes. Also, should we more broadly convert anything invalid here, not just '.'? Could there be spaces, umlauts, double colons... (not sure, probably flexforms don't allow these)? -
Georg Ringer uploaded patch set 2
V +109/02/26, 16:48 -
core-ci voted on patch set 2 V +1 09/02/26, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107660
-
Wouter Wolters voted on patch set 2 CR +1 V +1 09/02/26, 19:05
-
Garvin Hicking commented on patch set 2 09/02/26, 19:06
Commit message/title needs adjustment, right? IIRC we use a bootstrap replacement now (our own) so maybe we need to adjust the code comment for that tooInlineStackProcessor.php:216ReplyDone -
Georg Ringer rebased onto patch set 3
CR +1V +110/02/26, 16:08 -
Georg Ringer commented on patch set 2 10/02/26, 16:08
Reply
Title and message are adjusted. Regarding Bootstrap: backend still bundles upstream Bootstrap 5.3.2 (Contrib/bootstrap.js), which only runs CSS.escape on href targets, not on data-bs-target - so the code comment is still accurate. -
Wouter Wolters voted on patch set 3 CR +1 V +1 10/02/26, 16:15
-
core-ci voted on patch set 3 V +1 10/02/26, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109968
-
Garvin Hicking uploaded patch set 4
CR +1V +110/20/26, 13:51 -
Garvin Hicking voted on patch set 4 CR +1 V +1 10/20/26, 13:51
-
core-ci voted on patch set 4 V +1 10/20/26, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111839
-
Matthias Vogel voted on patch set 4 CR +1 V +1 10/20/26, 14:04
-
Garvin Hicking voted on patch set 4 CR +2 V +2 10/20/26, 14:05
-
Garvin Hicking merged patch set 5 10/20/26, 14:17