Review main Merged

94596[BUGFIX] Allow expanding inline records in dotted FlexForm fields

Georg Ringer CR +2 V +2 Normal +135 −2 updated 10/20/26, 14:17

Commit message

Inline and file reference records could not be expanded when the
FlexForm field identifier contains a dot, e.g. "settings.image".

The dot ends up in the id of the collapsible panel, and the toggle
button referenced it via data-bs-target="#…". Bootstrap passes that
value unescaped to querySelector(), which treats the dot as a class
selector, so no element is found and nothing happens on click.

The toggle now uses an attribute selector [id="…"], which matches
the id verbatim, including dots.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Matthias Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1418

  1. Georg Ringer uploaded patch set 1 06/26/26, 11:06

  2. Georg Ringer commented on patch set 1 06/26/26, 11:06

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 06/26/26, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103937

  4. Garvin Hicking commented on patch set 1 06/26/26, 17:45

    InlineStackProcessor.php:216

    Should this only be done in the `id` case? A dot is fine in `name` attributes. Also, should we more broadly convert anything invalid here, not just '.'? Could there be spaces, umlauts, double colons... (not sure, probably flexforms don't allow these)?
  5. Georg Ringer uploaded patch set 2 V +1 09/02/26, 16:48

  6. core-ci voted on patch set 2 V +1 09/02/26, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107660

  7. Wouter Wolters voted on patch set 2 CR +1 V +1 09/02/26, 19:05

  8. Garvin Hicking commented on patch set 2 09/02/26, 19:06

    Commit message/title needs adjustment, right? IIRC we use a bootstrap replacement now (our own) so maybe we need to adjust the code comment for that too

    InlineStackProcessor.php:216 Reply

    Done
  9. Georg Ringer rebased onto patch set 3 CR +1 V +1 10/02/26, 16:08

  10. Georg Ringer commented on patch set 2 10/02/26, 16:08

    Reply

    Title and message are adjusted. Regarding Bootstrap: backend still bundles upstream Bootstrap 5.3.2 (Contrib/bootstrap.js), which only runs CSS.escape on href targets, not on data-bs-target - so the code comment is still accurate.
  11. Wouter Wolters voted on patch set 3 CR +1 V +1 10/02/26, 16:15

  12. core-ci voted on patch set 3 V +1 10/02/26, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109968

  13. Garvin Hicking uploaded patch set 4 CR +1 V +1 10/20/26, 13:51

  14. Garvin Hicking voted on patch set 4 CR +1 V +1 10/20/26, 13:51

  15. core-ci voted on patch set 4 V +1 10/20/26, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111839

  16. Matthias Vogel voted on patch set 4 CR +1 V +1 10/20/26, 14:04

  17. Garvin Hicking voted on patch set 4 CR +2 V +2 10/20/26, 14:05

  18. Garvin Hicking merged patch set 5 10/20/26, 14:17