94601[BUGFIX] Apply an ellipsis to long URLs in CKEditor link toolbar
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 2
Review log 811
-
Maike Kiebele uploaded patch set 1 06/26/26, 15:21
-
core-ci voted on patch set 1 V -1 06/26/26, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103951
-
Maike Kiebele uploaded patch set 2
V -106/29/26, 06:53 -
core-ci voted on patch set 2 V -1 06/29/26, 07:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104006
-
Benjamin Franzke commented on patch set 2 06/29/26, 07:16
We should try to shorten this, to comply to: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html > Wrap it to 72 characters.typo3-rte-ckeditor-ckeditor5.scss:71Hm, it wraps niceley now, but the separator (`<span class="ck ck-toolbar__separator"></span>`) between link destination and control icons is now wrapped, and showed at the beginning of the block, where it makes no sense: https://snipboard.io/kBgGqb.jpg I'd propose a single-line ellipsis on `.ck-link-toolbar__preview` instead. What do you think? -
Benjamin Franzke uploaded patch set 3
V -106/29/26, 07:24 -
Benjamin Franzke commented on patch set 3 06/29/26, 07:24
Reply
Donetypo3-rte-ckeditor-ckeditor5.scss:71ReplyApplied in patchset 3, please reopen if you see concerns. -
core-ci voted on patch set 3 V +1 06/29/26, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104011
-
Garvin Hicking commented on patch set 3 CR +1 V +1 06/29/26, 09:29
Thanks! Good for me with the overflow, thought similar that linewrapping might not be too helpful. -
Garvin Hicking voted on patch set 3 CR +2 V +2 06/29/26, 09:30
-
Garvin Hicking merged patch set 4 06/29/26, 11:29