94605[BUGFIX] Allow database names containing a dot in schema migration
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1013
-
Georg Ringer uploaded patch set 1 06/26/26, 17:22
-
Georg Ringer commented on patch set 1 06/26/26, 17:22
This change is ready for review. -
core-ci voted on patch set 1 V -1 06/26/26, 17:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103956
-
core-ci voted on patch set 1 V +1 06/30/26, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103956
-
Stefan Bürk commented on patch set 1 CR -1 08/02/26, 17:06
Thanks for tracking this down - the fix is correct: it removes the default-namespace asymmetry between the expected and the introspected schema (the "to" side used the raw database name, the "from" side uses getCurrentSchemaName(), which is null on MySQL/MariaDB/SQLite), so a dotted database name no longer collapses every table onto the same key.One point on the Releases footer: it currently targets "main, 14.3", but this is a v13 regression. The reporter notes it did not happen on v12, and it was confirmed on 13.4.22 in the issue (#108028). Since the change is behaviour-preserving on normal database names, it should be safe to backport. v13 uses currently the same doctrine/dbal version anyway, so I go to extend Releases to "main, 14.3, 13.4".ConnectionMigrator.php:321This creates now a new schema manager here, while `buildSchemaDiff()`, the only place calling this method already have one and I'd like that we pass the instance instead of creating a new one. `->getName()`: a short comment on why this indirection is needed (getCurrentSchemaName() is protected) would help the next reader not "simplify" it back into the bug. -
Stefan Bürk uploaded patch set 2
CR -1V +108/02/26, 17:15 -
Stefan Bürk commented on patch set 2 08/02/26, 17:18
Reply
DoneConnectionMigrator.php:321ReplyDone -
core-ci voted on patch set 2 V +1 08/02/26, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105853
-
Stefan Bürk voted on patch set 2 CR +1 V +1 08/02/26, 17:25
-
Georg Ringer voted on patch set 2 CR +1 V +1 08/05/26, 09:22
-
Garvin Hicking voted on patch set 2 CR +1 V +1 08/27/26, 16:06
-
Stefan Bürk voted on patch set 2 CR +2 V +2 08/31/26, 07:27
-
Stefan Bürk merged patch set 3 08/31/26, 07:52