Review main Merged

94607[TASK] Mark disabled pages in language comparison

Amir Arends CR +2 V +2 Easy +6 −0 updated 06/29/26, 17:20

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benjamin Kott +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benjamin Kott +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1620

  1. Amir Arends uploaded patch set 1 06/28/26, 19:52

  2. core-ci voted on patch set 1 V +1 06/28/26, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103991

  3. Garvin Hicking commented on patch set 1 06/29/26, 04:50

    That's nice, thanks! I think we might want to classify this as a "task" due to being a smaller patch - otherwise a feature would also need a ReST changelog file. What do you think?
  4. Amir Arends updated the commit message in patch set 2 V +1 06/29/26, 05:51

  5. core-ci voted on patch set 2 V +1 06/29/26, 05:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104005

  6. Amir Arends commented on patch set 2 06/29/26, 06:22

    Reply

    Good point, thank you! I changed the classification.
  7. Amir Arends updated the commit message in patch set 3 V +1 06/29/26, 07:04

  8. core-ci voted on patch set 3 V +1 06/29/26, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104010

  9. Josua Vogel commented on patch set 3 CR +1 V +1 06/29/26, 07:24

    Love it - thanks!
  10. Garvin Hicking voted on patch set 3 CR +1 V +1 06/29/26, 09:28

  11. Benjamin Kott commented on patch set 3 06/29/26, 11:15

    Thx for the patch! It's the first time we would actively overlay a flag with a disabled icon here, and from my perspective it´s really hard to see - i would not notice the overlay if i am not actively looking for it. Maybe we can simply add the normal record icon with the overlay in Front or add a dedicated badge?
  12. Amir Arends uploaded patch set 4 CR +1 V +1 06/29/26, 13:23

  13. Amir Arends commented on patch set 4 06/29/26, 13:26

    Reply

    Using the iconForRecord ViewHelper is actually really nice here: it renders the correct page icon for each column based on the page's doktype automatically. So we do not hardcode any overlay ourselves, and the disabled state ends up far more noticeable. I have placed it in front of the flag.
  14. core-ci voted on patch set 4 V +1 06/29/26, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104033

  15. Benjamin Kott voted on patch set 4 CR +1 V +1 06/29/26, 15:20

  16. Benjamin Kott commented on patch set 4 06/29/26, 15:21

    Reply

    Thx for the adjustments, it looks more noticeable right now!
  17. Garvin Hicking voted on patch set 4 CR +1 V +1 06/29/26, 15:22

  18. Simon Schaufelberger voted on patch set 4 CR +1 V +1 06/29/26, 16:27

  19. Garvin Hicking voted on patch set 4 CR +2 V +2 06/29/26, 16:29

  20. Garvin Hicking merged patch set 5 06/29/26, 17:20