94614[TASK] Implement and apply custom PHPStan rule to harden `unserialize`
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oliver Hader +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 12
- Build/phpstan/src/Rules/Classes/UnserializeRule.phpnew+201 −0
- Build/phpstan/phpstan.neon+4 −0
- typo3/sysext/core/Classes/Package/Cache/PackageCacheEntry.php3+45 −2
- typo3/sysext/core/Classes/Package/PackageManager.php+2 −1
- typo3/sysext/core/Classes/Serializer/AuthenticatedMessageDeserializer.php+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/AST/AstBuilderInterfaceTest.php+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/SysTemplateTreeBuilderTest.php+1 −0
- typo3/sysext/core/Tests/Unit/TypoScript/AST/AstBuilderInterfaceTest.php+1 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+1 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/LazyLoadingProxyTest.php+1 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/LazyObjectStorageTest.php+1 −0
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+1 −0
Review log 911
-
Elias Häußler uploaded patch set 1 06/29/26, 13:13
-
core-ci voted on patch set 1 V -1 06/29/26, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104032
-
Simon Schaufelberger commented on patch set 1 06/29/26, 13:21
-
Elias Häußler commented on patch set 1 06/29/26, 13:24
PackageCacheEntry.php:51Reply`StatesConfiguration` is a PHPStan type (see https://review.typo3.org/c/Packages/TYPO3.CMS/+/94614/1/typo3/sysext/core/Classes/Package/Cache/PackageCacheEntry.php#34 and https://review.typo3.org/c/Packages/TYPO3.CMS/+/94614/1/typo3/sysext/core/Classes/Package/PackageManager.php#52). As such, it resolves to an array. -
core-ci voted on patch set 1 V +1 06/29/26, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104032
-
Simon Schaufelberger commented on patch set 1 CR +1 06/29/26, 13:39
PackageCacheEntry.php:51ReplyAcknowledged -
Garvin Hicking voted on patch set 1 CR +1 V +1 06/29/26, 16:34
-
Oliver Hader commented on patch set 1 CR +1 V +1 07/01/26, 10:07
Nice ❤️ -
Oliver Klee voted on patch set 1 V +1 07/01/26, 11:53
-
Garvin Hicking voted on patch set 1 CR +2 V +2 07/01/26, 16:43
-
Garvin Hicking merged patch set 2 07/01/26, 16:44
PackageCacheEntry.php:51