94632[TASK] Identify remote packages by key, version and remote
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/extensionmanager/Classes/Controller/DistributionController.php+3 −2
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php2+23 −15
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+14 −0
- typo3/sysext/extensionmanager/Classes/Domain/Model/PackageIdentifier.php2new+35 −0
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php4+32 −0
- typo3/sysext/extensionmanager/Classes/Property/TypeConverter/PackageIdentifierTypeConverter.phpnew+55 −0
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php1+3 −3
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php+7 −1
- typo3/sysext/extensionmanager/Configuration/Services.yaml+7 −0
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/Distribution.fluid.html+5 −5
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/UnresolvedDependencies.fluid.json+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/Distribution/Show.fluid.html+2 −2
- typo3/sysext/extensionmanager/Resources/Private/Templates/Download/InstallFromTer.fluid.json+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/PackageIdentifierTest.phpnew+52 −0
- typo3/sysext/extensionmanager/Tests/Unit/Property/TypeConverter/PackageIdentifierTypeConverterTest.phpnew+72 −0
- typo3/sysext/extensionmanager/Tests/Unit/Service/ExtensionManagementServiceTest.php+1 −2
Review log 1123
-
Benni Mack uploaded patch set 1 06/30/26, 12:11
-
core-ci voted on patch set 1 V +1 06/30/26, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104082
-
Oli Bartsch commented on patch set 1 06/30/26, 14:16
PackageIdentifier.php:32version should be required. No install/download action legitimately omits a version, so the default is superfluous and might lead to errors in the future.ExtensionRepository.php:130I would like to clarify the remote optionality here. IMO either make remote required and always apply the constraint, or rename the method to signal it's a best-effort lookup and add a docblock explaining the ambiguity when two remotes share the same key and version. If the caller genuinely doesn't know the remote, that's a separate use case that deserves its own method (e.g. findAllByPackageKeyAndVersion) returning a collection, not silently picking one.ExtensionRepository.php:164Do we still need this method? -
Oli Bartsch uploaded patch set 2
V +106/30/26, 16:11 -
core-ci voted on patch set 2 V +1 06/30/26, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104090
-
Oli Bartsch uploaded patch set 3
V +107/02/26, 12:26 -
Oli Bartsch commented on patch set 3 07/02/26, 12:27
This change is ready for review.DownloadController.php:59ReplyDonePackageIdentifier.php:32ReplyDoneExtensionRepository.php:130ReplyDoneExtensionRepository.php:164ReplyDone -
core-ci voted on patch set 3 V -1 07/02/26, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104234
-
core-ci commented on patch set 3 07/02/26, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104234
-
core-ci commented on patch set 3 07/02/26, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104234
-
core-ci commented on patch set 3 07/02/26, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104234
-
core-ci commented on patch set 3 07/02/26, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104234
-
core-ci commented on patch set 3 07/02/26, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104234
-
core-ci commented on patch set 3 07/02/26, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104234
-
core-ci commented on patch set 3 07/02/26, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104234
-
core-ci commented on patch set 3 07/02/26, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104234
-
core-ci voted on patch set 3 V +1 07/02/26, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104234
-
Oli Bartsch voted on patch set 3 CR +1 V +1 07/02/26, 19:13
-
Stefan Bürk voted on patch set 3 CR +1 V +1 07/02/26, 19:35
-
Benni Mack voted on patch set 3 CR +2 V +2 07/02/26, 19:40
-
Benni Mack merged patch set 4 07/02/26, 19:42
-
Benjamin Franzke commented on patch set 4 07/08/26, 09:11
ExtensionManagementService.php:287 -
Benjamin Franzke wrote 07/08/26, 09:32
Created a revert of this change as I251fa9167c26d24c97141c570ce06b5917f50eeb
DownloadController.php:59