Review main Merged

94636[TASK] Use Dependency Injection over makeInstance where applicable

Benni Mack CR +2 V +2 Hard +213 −150 updated 07/01/26, 11:56

Commit message

In order to unify all usages and identify
issues of classes that use makeInstance
even though they shouldn't, this patch migrates
most of the easy use-cases (ViewHelpers etc) to
Dependency Injection over makeInstance.

This is a first step into unifying DependencyInjection
in TYPO3 Core, with more changes following up on that.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 43

Show 23 more files

Review log 1318

  1. Benni Mack uploaded patch set 1 06/30/26, 23:05

  2. core-ci voted on patch set 1 V -1 06/30/26, 23:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104094

  3. Benni Mack uploaded patch set 2 V -1 07/01/26, 06:57

  4. core-ci voted on patch set 2 V -1 07/01/26, 07:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104117

  5. Benni Mack uploaded patch set 3 V -1 07/01/26, 07:14

  6. core-ci voted on patch set 3 V -1 07/01/26, 07:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104119

  7. Benni Mack uploaded patch set 4 V -1 07/01/26, 07:35

  8. core-ci voted on patch set 4 V +1 07/01/26, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104123

  9. Benni Mack updated the commit message in patch set 5 V +1 07/01/26, 08:50

  10. Benni Mack marked it ready for review 07/01/26, 08:50

  11. Oliver Klee voted on patch set 5 V +1 07/01/26, 08:51

  12. Oliver Klee voted on patch set 5 CR +1 07/01/26, 08:54

  13. core-ci voted on patch set 5 V +1 07/01/26, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104141

  14. Simon Schaufelberger voted on patch set 5 CR +1 V +1 07/01/26, 09:22

  15. Benjamin Franzke commented on patch set 5 CR -1 07/01/26, 09:29

    reviewing
  16. Benjamin Franzke commented on patch set 5 CR +1 V +1 07/01/26, 09:44

    Reply

    Done
  17. Benni Mack voted on patch set 5 CR +2 V +2 07/01/26, 11:56

  18. Benni Mack merged patch set 6 07/01/26, 11:56