94636[TASK] Use Dependency Injection over makeInstance where applicable
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Oliver Klee +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 43
- typo3/sysext/backend/Classes/Controller/FormFilesAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+3 −3
- typo3/sysext/backend/Classes/Controller/MfaConfigurationController.php+2 −2
- typo3/sysext/backend/Classes/Controller/MfaSetupController.php+2 −1
- typo3/sysext/backend/Classes/Controller/SwitchUserController.php+3 −3
- typo3/sysext/backend/Classes/ViewHelpers/TypoScript/FineDiffViewHelper.php+5 −3
- typo3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php+3 −4
- typo3/sysext/backend/Classes/ViewHelpers/ThumbnailViewHelper.php+3 −6
- typo3/sysext/backend/Tests/Functional/Controller/MfaConfigurationControllerTest.php+1 −0
- typo3/sysext/backend/Tests/Functional/Controller/MfaSetupControllerTest.php+1 −0
- typo3/sysext/backend/Tests/Unit/Controller/FormInlineAjaxControllerTest.php+10 −9
- typo3/sysext/beuser/Classes/ViewHelpers/MfaStatusViewHelper.php+8 −4
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+5 −6
- typo3/sysext/core/Classes/LinkHandling/LinkService.php+4 −3
- typo3/sysext/core/Classes/ViewHelpers/IconViewHelper.php+5 −3
- typo3/sysext/core/Tests/Functional/Html/EventListener/RteHtmlParserTest.php+5 −4
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/TypoLinkSoftReferenceParserTest.php+7 −0
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/TypoLinkTagSoftReferenceParserTest.php+7 −0
- typo3/sysext/core/Tests/Unit/Html/RteHtmlParserTest.php+25 −28
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php+3 −2
Show 23 more files
- typo3/sysext/core/Tests/Unit/LinkHandling/LinkServiceTest.php+7 −6
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php+3 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Be/InfoboxViewHelper.php+5 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CountrySelectViewHelper.php+7 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Form/UploadDeleteCheckboxViewHelper.php+2 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php+3 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+6 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Render/RecordViewHelper.php+2 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Transform/HtmlViewHelper.php+5 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php+6 −3
- typo3/sysext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php+3 −4
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php+3 −5
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php+10 −9
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php+5 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/TypolinkViewHelperTest.php+3 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/TypolinkViewHelperTest.php+4 −2
- typo3/sysext/form/Classes/ViewHelpers/Be/RenderContentElementPreviewViewHelper.php+2 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderFormValueViewHelper.php+5 −2
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+3 −3
- typo3/sysext/frontend/Classes/Resource/FileCollector.php+2 −3
- typo3/sysext/frontend/Tests/Unit/Typolink/EmailLinkBuilderTest.php+4 −3
- typo3/sysext/install/Classes/ServiceProvider.php+18 −0
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+1 −1
Review log 1318
-
Benni Mack uploaded patch set 1 06/30/26, 23:05
-
core-ci voted on patch set 1 V -1 06/30/26, 23:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104094
-
Benni Mack uploaded patch set 2
V -107/01/26, 06:57 -
core-ci voted on patch set 2 V -1 07/01/26, 07:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104117
-
Benni Mack uploaded patch set 3
V -107/01/26, 07:14 -
core-ci voted on patch set 3 V -1 07/01/26, 07:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104119
-
Benni Mack uploaded patch set 4
V -107/01/26, 07:35 -
core-ci voted on patch set 4 V +1 07/01/26, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104123
-
Benni Mack updated the commit message in patch set 5
V +107/01/26, 08:50 -
Benni Mack marked it ready for review 07/01/26, 08:50
-
Oliver Klee voted on patch set 5 V +1 07/01/26, 08:51
-
Oliver Klee voted on patch set 5 CR +1 07/01/26, 08:54
-
core-ci voted on patch set 5 V +1 07/01/26, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104141
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 07/01/26, 09:22
-
Benjamin Franzke commented on patch set 5 CR -1 07/01/26, 09:29
reviewing -
Benjamin Franzke commented on patch set 5 CR +1 V +1 07/01/26, 09:44
Reply
Done -
Benni Mack voted on patch set 5 CR +2 V +2 07/01/26, 11:56
-
Benni Mack merged patch set 6 07/01/26, 11:56