94650[TASK] Use Dependency Injection in Fluid ViewHelpers
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Stefan Bürk +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Stefan Bürk +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/belog/Classes/ViewHelpers/Be/PagePathViewHelper.phpdeleted+0 −44
- typo3/sysext/beuser/Classes/ViewHelpers/SpriteIconForRecordViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuViewHelper.php+7 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php+2 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PagePathViewHelper.php+2 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php+11 −14
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+11 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Be/UriViewHelper.php+2 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Sanitize/HtmlViewHelper.php+7 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php3+7 −9
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/PageViewHelper.php+12 −9
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php4+14 −16
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php+9 −9
- typo3/sysext/install/Classes/ServiceProvider.php+10 −0
Review log 1624
-
Benni Mack uploaded patch set 1 07/01/26, 14:52
-
Benni Mack marked it ready for review 07/01/26, 15:03
-
Simon Schaufelberger commented on patch set 1 07/01/26, 15:11
ImageViewHelper.php:111use $this->imageService here? -
core-ci voted on patch set 1 V -1 07/01/26, 15:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104158
-
Benni Mack commented on patch set 1 07/01/26, 15:36
CObjectViewHelper.php:130Replyyeah, good point. care to update the patch?ImageViewHelper.php:111Replysee above -
Simon Schaufelberger commented on patch set 1 07/01/26, 21:25
CObjectViewHelper.php:130Replyon it -
Simon Schaufelberger uploaded patch set 2
V -107/01/26, 21:30 -
Simon Schaufelberger commented on patch set 1 07/01/26, 21:31
CObjectViewHelper.php:130ReplyDoneImageViewHelper.php:111ReplyDone -
core-ci voted on patch set 2 V -1 07/01/26, 21:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104208
-
Oliver Klee voted on patch set 2 V +1 07/02/26, 07:37
-
core-ci commented on patch set 2 07/02/26, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104208
-
Benni Mack uploaded patch set 3
V +107/02/26, 09:39 -
Benni Mack marked it ready for review 07/02/26, 09:39
-
core-ci voted on patch set 3 V -1 07/02/26, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104222
-
core-ci commented on patch set 3 07/02/26, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104222
-
core-ci commented on patch set 3 07/02/26, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104222
-
Benni Mack rebased onto patch set 4
V -107/02/26, 11:06 -
core-ci voted on patch set 4 V -1 07/02/26, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104230
-
core-ci voted on patch set 4 V +1 07/02/26, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104230
-
Oliver Klee voted on patch set 4 CR +1 V +1 07/02/26, 14:47
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 07/02/26, 15:20
-
Stefan Bürk voted on patch set 4 CR +1 V +1 07/02/26, 15:29
-
Benni Mack commented on patch set 4 CR +2 V +2 07/02/26, 15:29
thanks -
Benni Mack merged patch set 5 07/02/26, 15:29
CObjectViewHelper.php:130