Review main Merged

94650[TASK] Use Dependency Injection in Fluid ViewHelpers

Benni Mack CR +2 V +2 Normal +96 −125 updated 07/02/26, 15:29

Commit message

Following up on the initial DI migration, this converts further
ViewHelpers to constructor dependency injection instead of
GeneralUtility::makeInstance() and static service-locator helpers.

Backend ViewHelpers no longer extend AbstractBackendViewHelper and
instead receive PageRenderer and other stateless services through the
constructor. Static helper methods that merely fetched shared services
(getPageRenderer(), getConfigurationManager(), getImageService() and
friends) are turned into injected dependencies.

The obsolete and @internal belog PagePathViewHelper is removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1624

  1. Benni Mack uploaded patch set 1 07/01/26, 14:52

  2. Benni Mack marked it ready for review 07/01/26, 15:03

  3. Simon Schaufelberger commented on patch set 1 07/01/26, 15:11

    CObjectViewHelper.php:130

    should we always use this->timeTracker instead?

    ImageViewHelper.php:111

    use $this->imageService here?
  4. core-ci voted on patch set 1 V -1 07/01/26, 15:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104158

  5. Benni Mack commented on patch set 1 07/01/26, 15:36

    CObjectViewHelper.php:130 Reply

    yeah, good point. care to update the patch?

    ImageViewHelper.php:111 Reply

    see above
  6. Simon Schaufelberger commented on patch set 1 07/01/26, 21:25

    CObjectViewHelper.php:130 Reply

    on it
  7. Simon Schaufelberger uploaded patch set 2 V -1 07/01/26, 21:30

  8. Simon Schaufelberger commented on patch set 1 07/01/26, 21:31

    CObjectViewHelper.php:130 Reply

    Done

    ImageViewHelper.php:111 Reply

    Done
  9. core-ci voted on patch set 2 V -1 07/01/26, 21:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104208

  10. Oliver Klee voted on patch set 2 V +1 07/02/26, 07:37

  11. core-ci commented on patch set 2 07/02/26, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104208

  12. Benni Mack uploaded patch set 3 V +1 07/02/26, 09:39

  13. Benni Mack marked it ready for review 07/02/26, 09:39

  14. core-ci voted on patch set 3 V -1 07/02/26, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104222

  15. core-ci commented on patch set 3 07/02/26, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104222

  16. core-ci commented on patch set 3 07/02/26, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104222

  17. Benni Mack rebased onto patch set 4 V -1 07/02/26, 11:06

  18. core-ci voted on patch set 4 V -1 07/02/26, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104230

  19. core-ci voted on patch set 4 V +1 07/02/26, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104230

  20. Oliver Klee voted on patch set 4 CR +1 V +1 07/02/26, 14:47

  21. Simon Schaufelberger voted on patch set 4 CR +1 V +1 07/02/26, 15:20

  22. Stefan Bürk voted on patch set 4 CR +1 V +1 07/02/26, 15:29

  23. Benni Mack commented on patch set 4 CR +2 V +2 07/02/26, 15:29

    thanks
  24. Benni Mack merged patch set 5 07/02/26, 15:29