Review main Merged

94656[BUGFIX] Render scheduler task status consistently in module and CLI

Benjamin Kott CR +2 V +2 Hard +255 −76 updated 07/06/26, 05:55

Commit message

The scheduler backend module and the "scheduler:list" command resolved
and rendered a task's status flags (running, late, disabled, failure)
with separate, duplicated logic, so the two could report a task's state
differently and badge colours were lost (a failed task no longer showed
in red).

Introduce a shared TaskStatus value object and a buildTaskStatuses()
resolver in SchedulerTaskRepository so both derive the same statuses
from a single source of truth. The severity uses the core
ContextualFeedbackSeverity enum instead of hardcoded badge strings, and
labels use the domain key syntax (scheduler.messages:).

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1317

  1. Benjamin Kott uploaded patch set 1 07/01/26, 16:55

  2. Benjamin Kott updated the commit message in patch set 2 07/01/26, 16:56

  3. core-ci voted on patch set 1 V -1 07/01/26, 17:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104198

  4. core-ci voted on patch set 2 V -1 07/01/26, 17:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104199

  5. Benjamin Kott uploaded patch set 3 V -1 07/01/26, 17:18

  6. core-ci voted on patch set 3 V +1 07/01/26, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104201

  7. Garvin Hicking commented on patch set 3 CR +1 07/01/26, 19:56

    Nice! Will test thoroughly later the week if it's not merged by then. (I stumbled across this in the v14 scheduler rework, but was lacking time to address it, so much appreciated)
  8. Benjamin Franzke commented on patch set 3 CR -1 07/03/26, 08:34

    SchedulerTaskRepository.php:623

    Let's not translate within a repository (that is output and user-settings dependant and should therefore not be done in a repository, but during render). I see that we recently introduced the same for priorities, which I'd like to change though. See: > 94665: [TASK] Translate scheduler task priorities during rendering | https://review.typo3.org/c/Packages/TYPO3.CMS/+/94665
  9. Garvin Hicking commented on patch set 3 CR 0 V +1 07/03/26, 15:04

    SchedulerTaskRepository.php:623 Reply

    I've compared and verified this patch now; so when that pre-change is in I'm happy to get this one in too. I converted the CSV fixtures to actual SQL to test it, if it helps anyone: ``` INSERT INTO `tx_scheduler_task_group` (`uid`, `pid`, `tstamp`, `crdate`, `deleted`, `hidden`, `sorting`, `groupName`, `description`, `color`) VALUES (10, 0, 0, 0, 0, 1, 0, 'Hidden Group', NULL, '#FF0000'); INSERT INTO `tx_scheduler_task` (`tasktype`, `deleted`, `disable`, `description`, `task_group`, `parameters`, `execution_details`, `nextexecution`, `priority`, `serialized_executions`, `lastexecution_failure`) VALUES ('TYPO3\\CMS\\Scheduler\\Task\\CachingFrameworkGarbageCollectionTask', 0, 0, 'Overdue task', 0, '{}', '{"start":1000,"end":0,"interval":3600,"multiple":false,"cronCmd":"","isNewSingleExecution":false}', 500, 50, '', ''), ('TYPO3\\CMS\\Scheduler\\Task\\CachingFrameworkGarbageCollectionTask', 0, 1, 'Disabled task', 0, '{}', '{"start":1000,"end":0,"interval":3600,"multiple":false,"cronCmd":"","isNewSingleExecution":false}', 500, 50, '', ''), ('TYPO3\\CMS\\Scheduler\\Task\\CachingFrameworkGarbageCollectionTask', 0, 0, 'Running task', 0, '{}', '{"start":1000,"end":0,"interval":3600,"multiple":false,"cronCmd":"","isNewSingleExecution":false}', 5000000, 50, 'a:1:{i:0;i:500;}', ''), ('TYPO3\\CMS\\Scheduler\\Task\\CachingFrameworkGarbageCollectionTask', 0, 0, 'Overdue and failed task', 0, '{}', '{"start":1000,"end":0,"interval":3600,"multiple":false,"cronCmd":"","isNewSingleExecution":false}', 500, 50, '', 'a:2:{s:4:"code";i:1234;s:7:"message";s:4:"Boom";}'), ('TYPO3\\CMS\\Scheduler\\Task\\CachingFrameworkGarbageCollectionTask', 0, 0, 'Task in hidden group', 10, '{}', '{"start":1000,"end":0,"interval":3600,"multiple":false,"cronCmd":"","isNewSingleExecution":false}', 5000000, 50, '', ''), ('TYPO3\\CMS\\Scheduler\\Task\\CachingFrameworkGarbageCollectionTask', 0, 0, 'Failed task without message', 0, '{}', '{"start":1000,"end":0,"interval":3600,"multiple":false,"cronCmd":"","isNewSingleExecution":false}', 5000000, 50, '', 's:4:"oops";'); ```
  10. Benjamin Kott uploaded patch set 4 CR -1 V +1 07/03/26, 17:56

  11. Benjamin Kott commented on patch set 4 07/03/26, 17:56

    SchedulerTaskRepository.php:623 Reply

    Done
  12. core-ci voted on patch set 4 V +1 07/03/26, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104323

  13. Garvin Hicking commented on patch set 4 CR +1 V +1 07/03/26, 18:47

    If i applied these stacks of patches right, it seems to work 🤪
  14. Simon Schaufelberger voted on patch set 4 CR +1 V +1 07/03/26, 20:59

  15. Benjamin Kott voted on patch set 4 CR +2 V +2 07/04/26, 09:55

  16. Benjamin Kott merged patch set 5 07/04/26, 11:41

  17. Benjamin Franzke commented on patch set 5 07/06/26, 05:55

    SchedulerTaskRepository.php:623 Reply

    👍