94657[BUGFIX] Prevent PHP warning on invalid regex in replacement stdWrap
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 910
-
Georg Ringer uploaded patch set 1 07/01/26, 19:14
-
Georg Ringer commented on patch set 1 07/01/26, 19:14
This change is ready for review. -
core-ci voted on patch set 1 V +1 07/01/26, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104206
-
Garvin Hicking commented on patch set 1 07/03/26, 17:12
ContentObjectRenderer.php:1572Wbat about the elseif below, could happen there too? -
Georg Ringer commented on patch set 1 08/05/26, 10:22
ContentObjectRenderer.php:1572Replythe elseif ($useOptionSplitReplace) branch is safe: unlike the regex branch, it doesn't take a user-supplied pattern. It builds the pattern itself via preg_quote($search, '#') with fixed # delimiters, so the result is always compilable regardless of input (empty string, a lone backslash, #, null byte, …). The invalid-pattern problem only exists in the useRegExp branch, where the user provides the delimiters. So no additional guard is needed there. -
Oliver Klee voted on patch set 1 V +1 08/05/26, 10:35
-
Garvin Hicking commented on patch set 1 CR +1 V +1 08/05/26, 20:08
ContentObjectRenderer.php:1572ReplyDone -
Benni Mack voted on patch set 1 CR +1 V +1 08/12/26, 11:19
-
Georg Ringer voted on patch set 1 CR +2 V +2 08/12/26, 13:59
-
Georg Ringer merged patch set 2 08/12/26, 13:59